r108508 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108507‎ | r108508 | r108509 >
Date:15:40, 10 January 2012
Author:hashar
Status:reverted (Comments)
Tags:
Comment:
reverts $wgDeprecationWhitelist

There is no point in ignoring a deprecated function. The call really need
to be migrated OR the core function should not be deprecated if there is
any kind of valid usage.

If you really want to hide notifications, uses:
$wgDevelopmentWarnings = false;

Reverts r106993 r106946
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -3463,7 +3463,7 @@
34643464
34653465 MWDebug::deprecated( $function, $version, $component );
34663466
3467 - if ( !in_array( $function, $GLOBALS['wgDeprecationWhitelist'] ) && !isset( $functionsWarned[$function] ) ) {
 3467+ if ( !isset( $functionsWarned[$function] ) ) {
34683468 $functionsWarned[$function] = true;
34693469
34703470 if ( $version ) {
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -4107,16 +4107,6 @@
41084108 */
41094109 $wgDeprecationReleaseLimit = '1.17';
41104110
4111 -/**
4112 - * Function name whitelist for wfDeprecated warnings. You will not be warned
4113 - * for usage of deprecated functions in this list. This is mainly useful
4114 - * for extension developers unable to not use certain deprecated functions
4115 - * due to backward compatibility reasons.
4116 - * @since 1.19
4117 - * @var array
4118 - */
4119 -$wgDeprecationWhitelist = array();
4120 -
41214111 /** Only record profiling info for pages that took longer than this */
41224112 $wgProfileLimit = 0.0;
41234113

Follow-up revisions

RevisionCommit summaryAuthorDate
r108615revert r108508 which reverted for no good reasonjeroendedauw14:11, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106946follow up to r106883, typo fixesjeroendedauw15:09, 21 December 2011
r106993Change "My response:" to "My responses:"bsitu22:16, 21 December 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   15:50, 10 January 2012

Ok, apparently I need to explain this once more - sort of getting tired of it, this is why I send a flipping email to the list with my reasoning.

Scenario: some interface gets changed for a valid reason in 1.19. You are an extension developer with an extension that needs to be compatible with 1.17 to 1.19. Now you do not have the time to put in code to handle both versions, which might be a lot of work depending on the interface change. So you want to ignore this usage of this detracted interface for now, and fix it later on. However, you want to get a warning as soon as you use some other detracted interface.

To me this very much comes off as a "fuck you" to extension developers.

#Comment by Moejoe000 (talk | contribs)   12:11, 11 January 2012

Reverts r106883 and r106946 (not r106993)

Status & tagging log