r108472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108471‎ | r108472 | r108473 >
Date:21:21, 9 January 2012
Author:aaron
Status:resolved
Tags:
Comment:
Fix r108185: file transform store op needs 'overwriteDest'
Modified paths:
  • /trunk/phase3/includes/filerepo/file/File.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/File.php
@@ -811,12 +811,13 @@
812812 // FileRepo::store(); getThumbPath() uses a different zone in some subclasses.
813813 $backend->prepare( array( 'dir' => dirname( $thumbPath ) ) );
814814 $status = $backend->store(
815 - array( 'src' => $tmpThumbPath, 'dst' => $thumbPath ),
 815+ array( 'src' => $tmpThumbPath, 'dst' => $thumbPath, 'overwriteDest' => 1 ),
816816 array( 'force' => 1, 'nonLocking' => 1, 'allowStale' => 1 )
817817 );
818818 if ( $status->isOK() ) {
819819 $thumb->setStoragePath( $thumbPath );
820820 } else {
 821+ var_dump($status->errors);
821822 $thumb = $this->transformErrorOutput( $thumbPath, $thumbUrl, $params, $flags );
822823 }
823824 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r108473Removed debug code from r108472aaron21:22, 9 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108185Partially reverted r108111: we can't assume subclasses put thumbnails in the....aaron23:35, 5 January 2012

Status & tagging log