r108465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108464‎ | r108465 | r108466 >
Date:19:41, 9 January 2012
Author:mglaser
Status:resolved (Comments)
Tags:
Comment:
Added installation instructions
Made path to SDK configurable
Modified paths:
  • /trunk/extensions/WindowsAzureSDK/README.txt (modified) (history)
  • /trunk/extensions/WindowsAzureSDK/WindowsAzureSDK.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WindowsAzureSDK/WindowsAzureSDK.php
@@ -26,19 +26,15 @@
2727 $wgExtensionCredits['other'][] = array(
2828 'path' => __FILE__,
2929 'name' => 'WindowsAzureSDK',
30 - 'author' => array( 'REALDOLMEN', 'Hallo Welt! Medienwerkstatt GmbH' ),
 30+ 'author' => array( 'REALDOLMEN', 'Hallo Welt! Medienwerkstatt GmbH', 'Robert Vogel' ),
3131 'url' => 'http://www.hallowelt.biz',
3232 'version' => '4.1.0',
3333 'descriptionmsg' => 'windowswzuresdk-desc',
3434 );
3535
3636 $dir = dirname(__FILE__) . '/';
37 -$wgExtensionMessagesFiles['WindowsAzureSDK'] = $dir . 'WindowsAzureSDK.i18n.php';
 37+$wgExtensionMessagesFiles['WindowsAzureSDK'] = $dir . 'WindowsAzureSDK.i18n.php';
3838
3939 if(!class_exists('Microsoft_WindowsAzure_Diagnostics_Manager')) {
40 - require_once( $dir.'lib/PHPAzure/library/Microsoft/AutoLoader.php' );
41 -}
42 -
43 -if (!defined( 'MICROSOFT_WINDOWS_AZURE_SDK_VERSION' )) {
44 - define( 'MICROSOFT_WINDOWS_AZURE_SDK_VERSION', '4.1.0' );
 40+ require_once( $wgWindowsAzureSDKRoot.'/library/Microsoft/AutoLoader.php' );
4541 }
\ No newline at end of file
Index: trunk/extensions/WindowsAzureSDK/README.txt
@@ -1 +1,12 @@
2 -This extension contains the Microsoft "Windows Azure SDK for PHP v4.1.0" (http://phpazure.codeplex.com/) by REALDOLMEN.
\ No newline at end of file
 2+==Installation==
 3+Download (http://phpazure.codeplex.com/) and extract the the "PHPAzure -
 4+Windows Azure SDK for PHP" by REALDOLMEN.
 5+
 6+Copy the WindowsAzureSDK extension to your <mediawiki>/extensions directory
 7+and add the following line to your LocalSettings.php:
 8+
 9+$wgWindowsAzureSDKRoot = '../path/to/phpazure';
 10+include_once( "$IP/../extensions/WindowsAzureSDK/WindowsAzureSDK.php" );
 11+
 12+Make sure the $wgWindowsAzureSDKRoot variable is defined before the include_once
 13+statement.
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r108737* Follow up r108465: fixed register globals vulnerability. Removed SDK path c...mglaser17:53, 12 January 2012

Comments

#Comment by Reedy (talk | contribs)   20:33, 9 January 2012

You should always explicitly set $wgWindowsAzureSDKRoot in your Extension, otherwise it's a register global_issue...

#Comment by Mglaser (talk | contribs)   17:54, 12 January 2012

Since the Azure SDK now comes with the extension, I removed the $wgWindowsAzureSDKRoot settings entirely. r108737 should fix this issue.

Status & tagging log