r108376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108375‎ | r108376 | r108377 >
Date:00:15, 9 January 2012
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Fix double-escaping in 108312
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -813,7 +813,7 @@
814814 $this->mPagetitle = $nameWithTags;
815815
816816 # change "<i>foo&amp;bar</i>" to "foo&bar"
817 - $this->setHTMLTitle( $this->msg( 'pagetitle' )->rawParams( htmlspecialchars( Sanitizer::stripAllTags( $nameWithTags ) ) ) );
 817+ $this->setHTMLTitle( $this->msg( 'pagetitle' )->rawParams( Sanitizer::stripAllTags( $nameWithTags ) )->escaped() );
818818 }
819819
820820 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r108807Fix for r108376: the whole string is already espcaed on output, no need to es...ialex13:30, 13 January 2012

Comments

#Comment by Hashar (talk | contribs)   14:16, 9 January 2012

I think the htmlspecialchars() is applied by the skin.

Status & tagging log