r108356 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108355‎ | r108356 | r108357 >
Date:16:38, 8 January 2012
Author:demon
Status:ok (Comments)
Tags:
Comment:
@group Broken rather than marking incomplete
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/XmlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/XmlTest.php
@@ -88,6 +88,9 @@
8989 $this->assertEquals( '</element>', Xml::closeElement( 'element' ), 'closeElement() shortcut' );
9090 }
9191
 92+ /**
 93+ * @group Broken
 94+ */
9295 public function testDateMenu( ) {
9396 $curYear = intval(gmdate('Y'));
9497 $prevYear = $curYear - 1;
@@ -138,7 +141,6 @@
139142 "Date menu year is the current one when not specified"
140143 );
141144
142 - $this->markTestIncomplete( "Broken" );
143145 // @todo FIXME: next month can be in the next year
144146 // test failing because it is now december
145147 $this->assertEquals(

Comments

#Comment by Hashar (talk | contribs)   15:52, 10 January 2012

Oh no. This one is cause dateMenu is really broken. Not the test.

Status & tagging log