r108341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108340‎ | r108341 | r108342 >
Date:00:52, 8 January 2012
Author:krinkle
Status:reverted (Comments)
Tags:
Comment:
Remove action=history from submit on HistoryAction
* Not needed, and not used. Is internally converted to "view" as much as possible.
* Fixes bug 33587
* See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6
* Other diff links from MediaWiki don't do this either
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/actions/HistoryAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -228,6 +228,7 @@
229229 all pages.
230230 * Files with IPTC blocks we can't read no longer prevent extraction of exif
231231 or other metadata.
 232+* (bug 33587) Remove action "historysubmit" from history pages.
232233
233234 === API changes in 1.19 ===
234235 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/actions/HistoryAction.php
——@@ -407,7 +407,6 @@
408408 $s = Html::openElement( 'form', array( 'action' => $wgScript,
409409 'id' => 'mw-history-compare' ) ) . "\n";
410410 $s .= Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) . "\n";
411 - $s .= Html::hidden( 'action', 'historysubmit' ) . "\n";
412411
413412 $s .= '<div>' . $this->submitButton( $this->msg( 'compareselectedversions' )->text(),
414413 array( 'class' => 'historysubmit' ) ) . "\n";

Follow-up revisions

RevisionCommit summaryAuthorDate
r108370[HistoryAction] Revert r108341 as this breaks revision delete....krinkle22:15, 8 January 2012
r108380[mediawiki.action.history.js] Provide cleaner handling of action=historysubmi...krinkle02:08, 9 January 2012

Comments

#Comment by Duplicatebug (talk | contribs)   10:19, 8 January 2012

Have you tested revisiondelete with IE from the history? For that reason 'historysubmit' was introduced with r57415.

#Comment by Krinkle (talk | contribs)   18:39, 8 January 2012

Thanks, I had not. I'm assuming this broke it, I'll will check it out and fix as soon as possible.

#Comment by Krinkle (talk | contribs)   03:05, 9 January 2012

Looks like the form being used for two very different purposes makes this impossible. Reverted in r108370.

Re-done in a non-breaking way from the front-end in r108380.

Status & tagging log