r108331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108330‎ | r108331 | r108332 >
Date:22:42, 7 January 2012
Author:platonides
Status:ok (Comments)
Tags:
Comment:
r102411 fixup. Close register globals vuln, and document
why is there that require_once.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php
——@@ -7,8 +7,14 @@
88 * @author Antoine Musso
99 * @group Database
1010 */
 11+
 12+if ( !defined( 'MEDIAWIKI' ) ) {
 13+ die( 1 );
 14+}
 15+
1116 global $IP;
12 -require_once("$IP/includes/QueryPage.php");
 17+require_once "$IP/includes/QueryPage.php"; // Needed to populate $wgQueryPages
 18+
1319 class QueryAllSpecialPagesTest extends MediaWikiTestCase {
1420
1521 /** List query pages that can not be tested automatically */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102411test SQL for our QueryPages objects...hashar16:22, 8 November 2011

Comments

#Comment by Hashar (talk | contribs)   11:55, 8 January 2012

Thanks

Status & tagging log