r108317 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108316‎ | r108317 | r108318 >
Date:12:29, 7 January 2012
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Register each i18n file in $wgExtensionMessagesFiles instead of loading one from the other; was giving me warnings about undefined magic word "languagename" while running parser tests.
Modified paths:
  • /trunk/extensions/I18nTags/I18nTags.i18n.php (modified) (history)
  • /trunk/extensions/I18nTags/I18nTags.php (modified) (history)

Diff [purge]

Index: trunk/extensions/I18nTags/I18nTags.i18n.php
——@@ -1,7 +1,5 @@
22 <?php
33
4 -require_once( dirname(__FILE__) . '/I18nTags.magic.php' );
5 -
64 $messages = array();
75
86 $messages['en'] = array(
Index: trunk/extensions/I18nTags/I18nTags.php
——@@ -22,6 +22,7 @@
2323 $dir = dirname(__FILE__) . '/';
2424 $wgAutoloadClasses['I18nTags'] = $dir . 'I18nTags_body.php';
2525 $wgExtensionMessagesFiles['I18nTags'] = $dir . 'I18nTags.i18n.php';
 26+$wgExtensionMessagesFiles['I18nTagsMagic'] = $dir . 'I18nTags.magic.php';
2627
2728 $wgHooks['ParserFirstCallInit'][] = 'efI18nTagsInit';
2829

Comments

#Comment by Siebrand (talk | contribs)   14:06, 7 January 2012

Nice catch. I thought we had taken care of all of these by now, but apparently not.

Status & tagging log