r108286 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108285‎ | r108286 | r108287 >
Date:22:07, 6 January 2012
Author:rmoen
Status:resolved (Comments)
Tags:
Comment:
added feedback dashboard leaderboard base styles and concurrency message to languge file
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /trunk/extensions/MoodBar/MoodBar.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -167,6 +167,7 @@
168168 'response-ajax-success-body' => 'Your response has been added.',
169169 'response-ajax-error-head' => 'Oops!',
170170 'response-ajax-error-body' => 'There was an error adding your response. <br />Please try again later.',
 171+ 'response-concurrency-notification' => 'Someone has recently started responding to this feedback.',
171172 //Email notification
172173 'moodbar-enotif-subject' => '$1 responded to your feedback',
173174
@@ -328,6 +329,7 @@
329330 'response-ajax-success-body' => 'Text for ajax status body on successful response (can be html)',
330331 'response-ajax-error-head' => 'Text for ajax status heading on error',
331332 'response-ajax-error-body' => 'Text for ajax status body on error (can be html)',
 333+ 'response-concurrency-notification' => 'Warning text explaining that another user has initiated a response to this feedback.',
332334 'moodbar-enotif-subject' => 'Feedback response email subject',
333335 'moodbar-enotif-body' => 'Feedback response email body, $1 is the commenter name, $2 is the link to the feedback of commenter, $3 is the responder talk page, $4 is the response text, $5 is commenter talk page',
334336 );
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css
@@ -87,6 +87,24 @@
8888 margin: 1em 0 0 0;
8989 }
9090
 91+/* Leader Board */
 92+.fbd-leaderboard {
 93+ margin: 0;
 94+ padding: 0;
 95+ list-style: none;
 96+}
 97+.fbd-leaderboard li{
 98+ margin: 0px;
 99+ padding: 2px 5px;
 100+ list-style: none;
 101+}
 102+
 103+.fbd-leaderboard li span {
 104+ float:right;
 105+ color: #777777;
 106+ font-weight: bold;
 107+}
 108+
91109 /* Tool Tip */
92110
93111 .fbd-tooltip-overlay-wrap {
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
@@ -509,6 +509,8 @@
510510 wikitext = wikitext.replace(/~{3,5}/g, '') + "\n\n~~~~"; //remove and add signature for
511511 parseWikiText($item, wikitext);
512512 });
 513+ //var $responseItem = $item.find('.fbd-item-response') ;
 514+ //loadToolTip($responseItem);
513515 }
514516 e.preventDefault();
515517 }
@@ -596,9 +598,8 @@
597599 }
598600 /* Display tooltip for response concurrency notification
599601 * @param $item Feedback item
600 - * @param msg Message to display in tooltip
601602 */
602 - function loadToolTip($item, msg) {
 603+ function loadToolTip($item) {
603604 var tooltip = $('<div>').attr('class', 'fbd-tooltip-overlay-wrap')
604605 .append(
605606 $('<div>').attr('class', 'fbd-tooltip-overlay')
@@ -606,7 +607,7 @@
607608 $('<div>').attr('class', 'fbd-tooltip-pointy')
608609 ).append(
609610 $('<div>').attr('class', 'fbd-tooltip-title')
610 - .text( msg )
 611+ .text( mw.msg( 'response-concurrency-notification' ) )
611612 .prepend(
612613 $('<span>').attr('class', 'fbd-tooltip-close').text('X')
613614 )
@@ -719,7 +720,6 @@
720721 $( 'input[type=checkbox].fbd-filters-check').prop('checked', false);
721722 $(this).prop('checked', true);
722723 }
723 -
724724 });
725725
726726 $( '#fbd-list' ).delegate( '.fbd-item', 'hover', function (){
Index: trunk/extensions/MoodBar/MoodBar.php
@@ -220,6 +220,7 @@
221221 'response-ajax-success-body',
222222 'response-ajax-error-head',
223223 'response-ajax-error-body',
 224+ 'response-concurrency-notification',
224225 ),
225226 );
226227

Follow-up revisions

RevisionCommit summaryAuthorDate
r108437remove commented test code. follow up r108286rmoen17:54, 9 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   10:22, 7 January 2012

Adds commented out code.

#Comment by Nikerabbit (talk | contribs)   10:22, 7 January 2012

Adds commented out code.

Status & tagging log