r108279 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108278‎ | r108279 | r108280 >
Date:20:25, 6 January 2012
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Doubleplusplusdoubled backticks
Modified paths:
  • /trunk/extensions/GeoData/ApiQueryCoordinates.php (modified) (history)
  • /trunk/extensions/GeoData/ApiQueryGeoSearch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GeoData/ApiQueryCoordinates.php
@@ -103,7 +103,7 @@
104104 'limit' => 'How many coordinates to return',
105105 'continue' => 'When more results are available, use this to continue',
106106 'prop' => 'What additional coordinate properties to return',
107 - 'primary' => "Whether to return only primary coordinates (`yes'), secondary (`no') or both (`yes|no')",
 107+ 'primary' => "Whether to return only primary coordinates (``yes''), secondary (``no'') or both (``yes|no'')",
108108 );
109109 }
110110
Index: trunk/extensions/GeoData/ApiQueryGeoSearch.php
@@ -38,10 +38,10 @@
3939 } elseif ( isset( $params['page'] ) ) {
4040 $t = Title::newFromText( $params['page'] );
4141 if ( !$t || !$t->canExist() ) {
42 - $this->dieUsage( "Invalid page title `{$params['page']}' provided", '_invalid-page' );
 42+ $this->dieUsage( "Invalid page title ``{$params['page']}'' provided", '_invalid-page' );
4343 }
4444 if ( !$t->exists() ) {
45 - $this->dieUsage( "Page `{$params['page']}' does not exist", '_nonexistent-page' );
 45+ $this->dieUsage( "Page ``{$params['page']}'' does not exist", '_nonexistent-page' );
4646 }
4747 $coord = GeoData::getPageCoordinates( $t );
4848 if ( !$coord ) {
@@ -181,10 +181,10 @@
182182 'radius' => 'Search radius in meters',
183183 'maxdim' => 'Restrict search to objects no larger than this, in meters',
184184 'limit' => 'Maximum number of pages to return',
185 - 'globe' => "Globe to search on (by default `{$wgDefaultGlobe}')",
 185+ 'globe' => "Globe to search on (by default ``{$wgDefaultGlobe}'')",
186186 'namespace' => 'Namespace(s) to search',
187187 'prop' => 'What additional coordinate properties to return',
188 - 'primary' => "Whether to return only primary coordinates (`yes'), secondary (`no') or both (`yes|no')",
 188+ 'primary' => "Whether to return only primary coordinates (``yes''), secondary (``no'') or both (``yes|no'')",
189189 );
190190 }
191191

Comments

#Comment by Nikerabbit (talk | contribs)   10:19, 7 January 2012

That's so 80s.

Status & tagging log