r108269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108268‎ | r108269 | r108270 >
Date:19:15, 6 January 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Debug code needs removing
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -1027,7 +1027,7 @@
10281028 getFormData: function () {
10291029 var data = {};
10301030 var rating = $.articleFeedbackv5.find( '.articleFeedbackv5-rating input:hidden' ).val();
1031 - if ( true ) { // '0' != rating ) {
 1031+ if ( '0' != rating ) {
10321032 data.rating = rating;
10331033 }
10341034 data.comment = $.articleFeedbackv5.find( '.articleFeedbackv5-comment textarea' ).val();
@@ -2760,7 +2760,6 @@
27612761 * @param object errors errors, indexed by field name
27622762 */
27632763 $.articleFeedbackv5.markFormErrors = function ( errors ) {
2764 - aft5_debug( 'got here' );
27652764 if ( '_api' in errors ) {
27662765 if ( typeof errors._api == 'object' ) {
27672766 if ( 'info' in errors._api ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1084701.18wmf1: MFT r108239, r108245, r108247, r108250, r108269, r108280catrope20:28, 9 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108250Fixed the error messaging logic: a string in the api field is a message; an o...rsterbin16:23, 6 January 2012

Status & tagging log