r108262 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108261‎ | r108262 | r108263 >
Date:18:15, 6 January 2012
Author:krinkle
Status:resolved
Tags:
Comment:
Add tooltip/accesskey to EditWatchlist
* Fixes bug 33565
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -120,6 +120,7 @@
121121 * (bug 10574) Add an option to allow all pages to be exported by Special:Export.
122122 * mediawiki.js Message object constructor is now publicly available as mw.Message.
123123 * (bug 29309) allow CSS class per tooltip (tipsy)
 124+* (bug 33565) Add accesskey/tooltip to submit buttons on Special:EditWatchlist.
124125
125126 === Bug fixes in 1.19 ===
126127 * $wgUploadNavigationUrl should be used for file redlinks if.
Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -419,6 +419,8 @@
420420 $form = new EditWatchlistNormalHTMLForm( $fields, $this->getContext() );
421421 $form->setTitle( $this->getTitle() );
422422 $form->setSubmitTextMsg( 'watchlistedit-normal-submit' );
 423+ # Used message keys: 'accesskey-watchlistedit-normal-submit', 'tooltip-watchlistedit-normal-submit'
 424+ $form->setSubmitTooltip('watchlistedit-normal-submit');
423425 $form->setWrapperLegendMsg( 'watchlistedit-normal-legend' );
424426 $form->addHeaderText( $this->msg( 'watchlistedit-normal-explain' )->parse() );
425427 $form->setSubmitCallback( array( $this, 'submitNormal' ) );
@@ -475,6 +477,8 @@
476478 $form = new HTMLForm( $fields, $this->getContext() );
477479 $form->setTitle( $this->getTitle( 'raw' ) );
478480 $form->setSubmitTextMsg( 'watchlistedit-raw-submit' );
 481+ # Used message keys: 'accesskey-watchlistedit-raw-submit', 'tooltip-watchlistedit-raw-submit'
 482+ $form->setSubmitTooltip('watchlistedit-raw-submit');
479483 $form->setWrapperLegendMsg( 'watchlistedit-raw-legend' );
480484 $form->addHeaderText( $this->msg( 'watchlistedit-raw-explain' )->parse() );
481485 $form->setSubmitCallback( array( $this, 'submitRaw' ) );
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -3138,6 +3138,8 @@
31393139 'tooltip-diff' => 'This is the text (tooltip) that appears when you hover the mouse over the "Show changes" button ({{msg|showdiff}}) on the edit page.',
31403140 'tooltip-compareselectedversions' => 'Tooltip of {{msg|compareselectedversions}} (which is used as button in history pages).',
31413141 'tooltip-watch' => '{{Identical|Add this page to your watchlist}}',
 3142+'tooltip-watchlistedit-normal-submit' => 'Tooltip for {{msg|watchlistedit-normal-submit}} (used as button on [[Special:EditWatchlist]]).',
 3143+'tooltip-watchlistedit-raw-submit' => 'Tooltip for {{msg|watchlistedit-raw-submit}} (used as button on [[Special:EditWatchlist/raw]]).',
31423144 'tooltip-rollback' => 'Tooltip of the rollback link on the history page and the diff view
31433145 {{Identical|Rollback}}
31443146 {{Identical|Revert}}',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3490,6 +3490,8 @@
34913491 'accesskey-blockip-block' => 's', # do not translate or duplicate this message to other languages
34923492 'accesskey-export' => 's', # do not translate or duplicate this message to other languages
34933493 'accesskey-import' => 's', # do not translate or duplicate this message to other languages
 3494+'accesskey-watchlistedit-normal-submit'=> 's', # do not translate or duplicate this message to other languages
 3495+'accesskey-watchlistedit-raw-submit'=> 's', # do not translate or duplicate this message to other languages
34943496
34953497 # Tooltip help for the actions
34963498 'tooltip-pt-userpage' => 'Your user page',
@@ -3558,6 +3560,8 @@
35593561 'tooltip-undo' => '"Undo" reverts this edit and opens the edit form in preview mode. It allows adding a reason in the summary.',
35603562 'tooltip-preferences-save' => 'Save preferences',
35613563 'tooltip-summary' => 'Enter a short summary',
 3564+'tooltip-watchlistedit-normal-submit' => 'Remove titles',
 3565+'tooltip-watchlistedit-raw-submit' => 'Update watchlist',
35623566
35633567 # Stylesheets
35643568 'common.css' => '/* CSS placed here will be applied to all skins */', # only translate this message to other languages if you have to change it

Follow-up revisions

RevisionCommit summaryAuthorDate
r108264wl edit tooltip messages from r108262hashar18:27, 6 January 2012
r108289Ignore the 2 new access message keys from r108262 for translationraymond22:26, 6 January 2012
r108291Register the 2 new access message keys from r108262 for meintenance filesraymond22:58, 6 January 2012

Status & tagging log