r108215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108214‎ | r108215 | r108216 >
Date:11:24, 6 January 2012
Author:santhosh
Status:ok (Comments)
Tags:krinkle, todo 
Comment:
Prevent #firstHeading overriding the language specific h1 height.
Ref Bug 30809
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -824,7 +824,7 @@
825825 h1:lang(sa),
826826 h1:lang(ta),
827827 h1:lang(te) {
828 - line-height: 1.5em;
 828+ line-height: 1.5em !important;
829829 }
830830 h2:lang(as), h3:lang(as), h4:lang(as), h5:lang(as), h6:lang(as),
831831 h2:lang(bn), h3:lang(bn), h4:lang(bn), h5:lang(bn), h6:lang(bn),

Sign-offs

UserFlagDate
Nikerabbitinspected15:10, 11 January 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r109053MFT r108713 r108215nikerabbit18:41, 16 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97788Zero padding for #firstHeading makes text cut for scripts like Devanagari , M...santhosh03:51, 22 September 2011
r99389Language specific height correction for titles. Ref Bug 29405 and Bug 30809. ...santhosh04:13, 10 October 2011

Comments

#Comment by Krinkle (talk | contribs)   12:37, 6 January 2012

If at all possible, we should consider looking for another way. I'm not marking fixme as I don't if it is inevitable in this case (tagging todo instead), but there should be no need for !important in core MediaWiki. Doing so makes future development harder than it needs to be.

#Comment by Siddhartha Ghai (talk | contribs)   01:06, 8 January 2012

Maybe bug 2013, bug 11325 and r32382 are relevant here?

Status & tagging log