r108210 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r108209‎ \| r108210 \| r108211 >
Date:	10:08, 6 January 2012
Author:	nikerabbit
Status:	reverted (Comments)
Tags:	backcompat
Comment:	Graaaaaah! Die die die legacy globals
Modified paths:	/trunk/extensions/SemanticMediaWiki/skins/SMW_tooltip.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/skins/SMW_tooltip.js
—	—	@@ -21,7 +21,7 @@
22	22	var tt = null; // the tooltip
23	23	var all_tt = []; // record all active tooltips
24	24
25		~~-var imagePath = wgScriptPath + '/extensions/SemanticMediaWiki/skins/images/';~~
	25	+var imagePath = mw.config.get( 'wgScriptPath' ) + '/extensions/SemanticMediaWiki/skins/images/';
26	26
27	27	// Dimensions of persistent tooltips
28	28	var SMWTT_WIDTH_P = 400;

Revision	Commit summary	Author	Date
r111458	revert r108210 (js wgScriptPath removal)...	hashar	13:51, 14 February 2012

#Comment by Jeroen De Dauw (talk | contribs) 15:24, 10 February 2012

This broke compat with 1.16 in 1.7.0.1 and 1.7.0.2. Please fix. SMW is keeping compat with 1.16.x until 1.8, when the min MW will become 1.17.

#Comment by Hashar (talk | contribs) 13:51, 14 February 2012

reverted with r111458

14:03, 14 February 2012 Jeroen De Dauw (talk | contribs) changed the tags for r108210 [removed: smw1.7.1]
13:51, 14 February 2012 Hashar (talk | contribs) changed the status of r108210 [removed: fixme added: reverted]
20:16, 11 February 2012 Jeroen De Dauw (talk | contribs) changed the tags for r108210 [added: smw1.7.1]
20:15, 11 February 2012 Jeroen De Dauw (talk | contribs) changed the tags for r108210 [added: backcompat]
15:24, 10 February 2012 Jeroen De Dauw (talk | contribs) changed the status of r108210 [removed: deferred added: fixme]