r108148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108147‎ | r108148 | r108149 >
Date:16:21, 5 January 2012
Author:ashley
Status:ok (Comments)
Tags:
Comment:
SolrStore: follow-up to r107212 -- fix typo spotted by Nikerabbit + general grammar tweaks
Modified paths:
  • /trunk/extensions/SolrStore/SolrConnectorStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SolrStore/SolrConnectorStore.php
@@ -170,9 +170,9 @@
171171 */
172172 public function getQueryResult( SMWQuery $query ) {
173173 // IF YOU SEE THIS HERE PLEASE IGNORE IT!
174 - // Our first aproche was it to create new SMWStore for querying data
175 - // but we had big problems recreating and parsing the SMW query syntax
176 - // that we just stopped at this point here.
 174+ // Our first approach was to create new SMWStore for querying data
 175+ // but we had big problems recreating and parsing the SMW query syntax,
 176+ // so we just stopped at this point here.
177177 // Maybe we will finish it someday
178178 $wgSolrTalker = new SolrTalker();
179179 if ( property_exists( $query, 'params' ) &&
@@ -186,10 +186,10 @@
187187
188188 echo( "SOLR query: {$query->getQueryString()}\n" );
189189
190 - echo 'Search is Powered by Solr!';
 190+ echo 'Search is powered by Solr!';
191191 echo $queryStr = urldecode( $wgSolrTalker->parseSolrQuery( $query->getQueryString() ) );
192192
193 - // Get Sort Parameters and add them to the QueryString
 193+ // Get sort parameters and add them to the query string
194194 if ( $query->sort ) {
195195 // TODO: Der Inhalt von Sort muss genau der Name eines der Felder von Solr sein
196196 // um danach Sortieren zu können. Deshalb Wird eine Liste alle Solr Felder
@@ -208,7 +208,7 @@
209209 echo 'Query Limit:' . $query->getLimit();
210210
211211 echo ( 'SEARCHRESULT: ' . $xml = $wgSolrTalker->solrQuery( $queryStr, $query->getOffset(), $query->getLimit() ) );
212 - echo '<br/>';
 212+ echo '<br />';
213213 // TODO: Move this code to parseSolrResult
214214 $numFound = $xml->result['numFound'];
215215 foreach ( $xml->result->doc as $doc ) {
@@ -248,7 +248,7 @@
249249 // Do we have more results?
250250 $more = false;
251251 // TODO: Does this work?
252 - echo 'Number of Records: ' . $numFound;
 252+ echo 'Number of records: ' . $numFound;
253253 if ( $numFound > 10 ) {
254254 $more = true;
255255 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107212SolrStore:...ashley16:53, 24 December 2011

Comments

#Comment by Johnduhart (talk | contribs)   16:33, 5 January 2012

I love the echos.

Status & tagging log