r108144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108143‎ | r108144 | r108145 >
Date:15:31, 5 January 2012
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
Special:ArticleFeedbackv5 page title now translatable

fix r105027
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -50,6 +50,8 @@
5151 'articlefeedbackv5-special-filter-label-after' => '',
5252 'articlefeedbackv5-special-showing' => 'Showing $1 posts (of $2)', // FIXME: Needs plural support on $1.
5353 'articlefeedbackv5-special-more' => 'More',
 54+ 'articlefeedbackv5-special-title' => 'Feedback for $1',
 55+
5456 'articlefeedbackv5-form-optionid' => 'Option $1',
5557 'articlefeedbackv5-form-hide' => 'Hide this ($1)',
5658 'articlefeedbackv5-form-abuse' => 'Flag as abuse ($1)',
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -18,7 +18,10 @@
1919 $found = isset( $ratings['found'] ) ? $ratings['found'] : null;
2020 $rating = isset( $ratings['rating'] ) ? $ratings['rating'] : null;
2121
22 - $out->setPagetitle( "Feedback for $title" );
 22+ $out->setPagetitle(
 23+ $this->msg( 'articlefeedbackv5-special-title', $title )
 24+ ->escaped()
 25+ );
2326
2427 if ( !$pageId ) {
2528 $out->addWikiMsg( 'articlefeedbackv5-invalid-page-id' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r108146rename message introduced in r108144...hashar15:49, 5 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105027Translation/localization improvements on AFTv5. Not perfect yet, but improved.gregchiasson23:39, 2 December 2011

Comments

#Comment by Johnduhart (talk | contribs)   15:41, 5 January 2012

Please add message documentation for the newly added messages. Thanks.

#Comment by Hashar (talk | contribs)   15:50, 5 January 2012

And the message was already there! Renamed it from:

articlefeedbackv5-special-title

to

articlefeedbackv5-special-pagetitle

Status & tagging log