r108115 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108114‎ | r108115 | r108116 >
Date:04:53, 5 January 2012
Author:mah
Status:ok (Comments)
Tags:
Comment:
Bug 33514 - Make category "columns" (table cells) equal width
Author: Erwin Dokter
Modified paths:
  • /trunk/phase3/includes/CategoryViewer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryViewer.php
@@ -486,10 +486,11 @@
487487 # Split into three columns
488488 $columns = array_chunk( $columns, ceil( count( $columns ) / 3 ), true /* preserve keys */ );
489489
490 - $ret = '<table width="100%"><tr valign="top"><td>';
 490+ $ret = '<table width="100%"><tr valign="top">';
491491 $prevchar = null;
492492
493493 foreach ( $columns as $column ) {
 494+ $ret .= '<td width="33.3%">';
494495 $colContents = array();
495496
496497 # Kind of like array_flip() here, but we keep duplicates in an
@@ -519,10 +520,10 @@
520521 $prevchar = $char;
521522 }
522523
523 - $ret .= "</td>\n<td>";
 524+ $ret .= "</td>\n";
524525 }
525526
526 - $ret .= '</td></tr></table>';
 527+ $ret .= '</tr></table>';
527528 return $ret;
528529 }
529530

Sign-offs

UserFlagDate
Nikerabbitinspected10:11, 5 January 2012

Comments

#Comment by Hashar (talk | contribs)   10:27, 5 January 2012

Nikerabbit, I am not sure why you marked this one new :-D

#Comment by Nikerabbit (talk | contribs)   10:29, 5 January 2012

Because I keep tabs open for a while and CR doesn't detect conflicts.

Status & tagging log