r108070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108069‎ | r108070 | r108071 >
Date:19:14, 4 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
r100516 didn't merge into 1.18wmf1 so well in r107970
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CentralAuth/specials/SpecialGlobalUsers.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CentralAuth/specials/SpecialGlobalUsers.php
@@ -9,7 +9,7 @@
1010 global $wgOut, $wgRequest, $wgContLang;
1111 $this->setHeaders();
1212
13 - $pg = new GlobalUsersPager( $this->getContext(), $par );
 13+ $pg = new GlobalUsersPager( $par );
1414
1515 if ( $par ) {
1616 $pg->setGroup( $par );
@@ -33,8 +33,8 @@
3434 class GlobalUsersPager extends UsersPager {
3535 protected $requestedGroup = false, $requestedUser;
3636
37 - function __construct( IContextSource $context = null, $par = null ) {
38 - parent::__construct( $context, $par );
 37+ function __construct( $par = null ) {
 38+ parent::__construct( $par );
3939 $this->mDb = CentralAuthUser::getCentralSlaveDB();
4040 }
4141

Follow-up revisions

RevisionCommit summaryAuthorDate
r108072Fix r104178 like r108070reedy19:16, 4 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100516Fix links on SpecialGlobalUsers, which were pointing to ListUsers instead of ...hartman20:55, 22 October 2011
r107970MFT r100516, r103260, r103315, r103378, r103382, r104862reedy00:08, 4 January 2012

Comments

#Comment by Duplicatebug (talk | contribs)   09:29, 8 January 2012

To fix the problem in 1.18 you have to override the getTitle method of UsersPager manually (see r91862 for an example), because 1.19 fix this with the ContextSource.

Status & tagging log