r108055 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108054‎ | r108055 | r108056 >
Date:17:30, 4 January 2012
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Bug 33494 - Remove redundant CSS from chick/main.css

Patch by Erwin Dokter
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -23,10 +23,6 @@
2424 a.new:visited,
2525 #p-personal a.new:visited { color:#a55858; }
2626
27 -img {
28 - border: none;
29 - vertical-align: middle;
30 -}
3127 p {
3228 margin: 0.4em 0em 0.5em 0em;
3329 line-height: 1.5em;
@@ -34,91 +30,10 @@
3531
3632 p img { margin: 0; }
3733
38 -hr {
39 - height: 1px;
40 - color: #aaaaaa;
41 - background-color: #aaaaaa;
42 - border: 0;
43 - margin: 0.2em 0 0.2em 0;
44 -}
45 -
46 -h1, h2, h3, h4, h5, h6 {
47 - color: black;
48 - background: none;
49 - font-weight: normal;
50 - margin: 0;
51 - overflow: hidden;
52 - padding-top: 0.5em;
53 - padding-bottom: 0.17em;
54 - border-bottom: 1px solid #aaaaaa;
55 -}
56 -.editsection {
57 - font-weight: normal;
58 -}
59 -h1 { font-size: 188%; }
60 -h1 .editsection { font-size: 53.2%; }
61 -h2 { font-size: 150%; }
62 -h2 .editsection { font-size: 66.7%; }
63 -h3, h4, h5, h6 {
64 - border-bottom: none;
65 - font-weight: bold;
66 -}
67 -h3 { font-size: 132%; }
68 -h3 .editsection { font-size: 75.8%; }
69 -h4 { font-size: 116%; }
70 -h4 .editsection { font-size: 86.2%; }
71 -h5 { font-size: 100%; }
72 -h6 { font-size: 80%; }
73 -h6 .editsection { font-size: 125%; }
74 -
75 -ul {
76 - line-height: 1.5em;
77 - margin: 0.3em 0 0 1.5em;
78 - padding:0;
79 -}
80 -ol {
81 - line-height: 1.5em;
82 - margin: 0.3em 0 0 3.2em;
83 - padding:0;
84 - list-style-image: none;
85 -}
86 -li { margin-bottom: 0.1em; }
87 -dt {
88 - font-weight: bold;
89 - margin-bottom: 0.1em;
90 -}
91 -dl{
92 - margin-top: 0.2em;
93 - margin-bottom: 0.5em;
94 -}
95 -dd {
96 - line-height: 1.5em;
97 - margin-left: 2em;
98 - margin-bottom: 0.1em;
99 -}
100 -
101 -fieldset {
102 - border: 1px solid #2f6fab;
103 - margin: 1em 0em 1em 0em;
104 - padding: 0em 1em 1em 1em;
105 - line-height: 1.5em;
106 -}
107 -legend {
108 - background: white;
109 - padding: 0.5em;
110 - font-size: 95%;
111 -}
112 -form {
113 - border: none;
114 - margin: 0;
115 -}
116 -
11734 textarea {
11835 border: 1px solid #2f6fab;
11936 color: black;
12037 background-color: white;
121 - width: 100%;
122 - padding: 0.1em;
12338 overflow: auto;
12439 }
12540 /* hide this from ie/mac and konq2.2 */
@@ -146,18 +61,9 @@
14762 color: black;
14863 vertical-align: top;
14964 }
150 -q {
151 - font-family: Times, "Times New Roman", serif;
152 - font-style: italic;
153 -}
 65+
15466 code { background-color: #f9f9f9; }
155 -pre {
156 - padding: 1em;
157 - border: 1px dashed #2f6fab;
158 - color: black;
159 - background-color: #f9f9f9;
160 - line-height: 1.1em;
161 -}
 67+pre { line-height: 1.1em; }
16268
16369 /*
16470 ** the main content area

Follow-up revisions

RevisionCommit summaryAuthorDate
r109714Reverting out r108055 for easereedy02:01, 22 January 2012

Comments

#Comment by Krinkle (talk | contribs)   01:44, 22 January 2012

Citing bug 33494:

This patch removes any redundant CSS from skins/chick/main.css that has moved
to skins/common/commonElement.css. I guess this was an oversight; it was
removed from all other skin files, but not this one.

Yes, but the "chick" skin does not load "commonElement.css" .

#Comment by Reedy (talk | contribs)   01:48, 22 January 2012

Probably easier just to revert this for 1.19 then

Status & tagging log