r107981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107980‎ | r107981 | r107982 >
Date:01:16, 4 January 2012
Author:khorn
Status:deferred
Tags:fundraising 
Comment:
followup r107609
I had a backwards bit. Also, defining the manual_errors array before we try to use it.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -169,6 +169,7 @@
170170 protected $dataObj;
171171 protected $transaction_results;
172172 protected $validation_errors;
 173+ protected $manual_errors = array();
173174 protected $current_transaction;
174175 protected $action;
175176 public $debugarray;
Index: trunk/extensions/DonationInterface/gateway_common/GatewayForm.php
@@ -111,9 +111,9 @@
112112 $check_not_empty = array_merge( $check_not_empty, $add_checks );
113113 }
114114
115 - $validate_errors = $this->adapter->revalidate( $check_not_empty );
 115+ $validated_ok = $this->adapter->revalidate( $check_not_empty );
116116
117 - return $validate_errors;
 117+ return !$validated_ok;
118118 }
119119
120120 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r112287MFT r101785, r105938, r105941, r105953, r106109, r106158, r106259, r106366, r...khorn01:29, 24 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107609Replacing most of the haphazard validation found throughout DonationInterface...khorn01:05, 30 December 2011

Status & tagging log