r107934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107933‎ | r107934 | r107935 >
Date:20:15, 3 January 2012
Author:ialex
Status:reverted (Comments)
Tags:
Comment:
Per Aaron, fix for r107771: Title::getTouched() should return false on non-existing page
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/includes/WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -342,7 +342,7 @@
343343 $this->mRedirect = false;
344344 $this->mLatestID = 0;
345345 $this->mCounter = 0;
346 - $this->mTouched = '19700101000000';
 346+ $this->mTouched = false;
347347 $this->mIsNew = false;
348348 $this->mOldRestrictions = false;
349349 $this->mLoadedLevel = 2;
@@ -3043,7 +3043,7 @@
30443044 $this->mLength = -1;
30453045 $this->mLatestID = false;
30463046 $this->mCounter = false;
3047 - $this->mTouched = '19700101000000';
 3047+ $this->mTouched = null;
30483048 $this->mIsNew = null;
30493049 $this->mEstimateRevisions = null;
30503050 $this->mLoadedLevel = 0;
Index: trunk/phase3/includes/WikiPage.php
@@ -499,7 +499,11 @@
500500 if ( !$this->mDataLoaded ) {
501501 $this->loadPageData();
502502 }
503 - return $this->mTitle->getTouched();
 503+ $timestamp = $this->mTitle->getTouched();
 504+ if ( $timestamp === false ) {
 505+ $timestamp = '19700101000000';
 506+ }
 507+ return $timestamp;
504508 }
505509
506510 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r107945Revert r107769, r107771, r107825, r107840, r107927, r107934...brion21:44, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107771Follow-up r107769:...ialex12:44, 1 January 2012

Comments

#Comment by Brion VIBBER (talk | contribs)   21:31, 3 January 2012

adding to the revert list

Status & tagging log