r107919 MediaWiki - Code Review archive

Of course the lame svn merge info are still there and the commit diff does not show up :-/

New documentation written:

• Manual:JavaScript unit testing
• Manual:Hooks/ResourceLoaderTestModules
• Manual:$wgEnableJavaScriptTest

The test suite is including tests from tests/, but that directory has .htaccess saying deny from all.

Fortunately ./tests/qunit has it's own .htaccess with Allow from all, and, atleast on my local install, local directories overwrite parent directories. If this doesn't work it means either Apache is misconfigured, or perhaps you have a hardcoded rule somewhere for ./tests that isn't in SVN ?

It's still not working for me: http://translatewiki.net/sw/Special:JavaScriptTest/qunit

0 tests of 0 passed, 0 failed.

Linker::link( $this->getTitle( $framework ), wfMsg( "javascripttest-$framework-name" ) )

Missing escaping. Should be wfMsgHtml.

> Linker::link( $this->getTitle( $framework ), wfMsg( "javascripttest-$framework-name" ) )

> Missing escaping. Should be wfMsgHtml.

Escaped with r108008

+'javascripttest-pagetext-frameworks' => '$1 is the if of the framework.',

if?

Issue addressed in one of the following commits.

+                               + mw.message( 'javascripttest-pagetext-skins' ).escaped()
+                               + mw.message( 'colon-separator' ).plain()

Please have the colon in the message itself. It should probably also say Choose skin (to run the tests with)

> Please have the colon in the message itself. It should probably also say Choose skin (to run the tests with)

Both fixed with r108010.

There are more messages that need escaping, like:

wfMsg( 'javascripttest-pagetext-noframework' ) . $this->getFrameworkListHtml(),

> There are more messages that need escaping, Escaped with r108008

Marking OK b/c you marked the follow-up ok.

addHtml doesn't take two params:

$out->addHtml( $summary, 'unknownframework' );

Fixed in r108007. The parameter was meant to be passed to wrapSummaryHtml() just above.

"This should be harmless". Have you looked at the size of the revision? :D

I'll take a crack at reviewing this one today or tomorrow.

Harmless to production since you need to set $wgEnableJavaScriptTest = true; :-D