r107903 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107902‎ | r107903 | r107904 >
Date:17:16, 3 January 2012
Author:catrope
Status:ok
Tags:
Comment:
Fix evil quirk in ClickTracking UDP output: '1' was output for logged-in users, but nothing was output for anons. This messes up the column-based nature of the data, so output '0' for anons instead
Modified paths:
  • /trunk/extensions/ClickTracking/ClickTracking.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/ClickTracking.hooks.php
——@@ -236,7 +236,7 @@
237237 // Replace tabs with spaces in all strings
238238 str_replace( "\t", ' ', $eventName ),
239239 wfTimestampNow(),
240 - (bool)$isLoggedIn,
 240+ (int)$isLoggedIn,
241241 str_replace( "\t", ' ', $sessionId ),
242242 (int)$namespace,
243243 (int)$contribs,

Follow-up revisions

RevisionCommit summaryAuthorDate
r1080161.18wmf1: MFT r107903catrope11:32, 4 January 2012

Status & tagging log