r107881 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107880‎ | r107881 | r107882 >
Date:11:57, 3 January 2012
Author:hashar
Status:reverted (Comments)
Tags:
Comment:
remove useless gender for english group name

Follow r99312
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -1908,12 +1908,14 @@
19091909 'group-suppress' => 'Oversights',
19101910 'group-all' => '(all)',
19111911
1912 -'group-user-member' => '{{GENDER:$1|user}}',
1913 -'group-autoconfirmed-member' => '{{GENDER:$1|autoconfirmed user}}',
1914 -'group-bot-member' => '{{GENDER:$1|bot}}',
1915 -'group-sysop-member' => '{{GENDER:$1|administrator}}',
1916 -'group-bureaucrat-member' => '{{GENDER:$1|bureaucrat}}',
1917 -'group-suppress-member' => '{{GENDER:$1|oversight}}',
 1912+# group names can use {{GENDER}} for language that make a distinction
 1913+# between male and female forms.
 1914+'group-user-member' => 'user',
 1915+'group-autoconfirmed-member' => 'autoconfirmed user',
 1916+'group-bot-member' => 'bot',
 1917+'group-sysop-member' => 'administrator',
 1918+'group-bureaucrat-member' => 'bureaucrat',
 1919+'group-suppress-member' => 'oversight',
19181920
19191921 'grouppage-user' => '{{ns:project}}:Users',
19201922 'grouppage-autoconfirmed' => '{{ns:project}}:Autoconfirmed users',
Index: trunk/phase3/languages/messages/MessagesQqq.php
——@@ -1527,12 +1527,12 @@
15281528
15291529 {{Identical|All}}',
15301530
1531 -'group-user-member' => '{{doc-group|user|member}}',
1532 -'group-autoconfirmed-member' => '{{doc-group|autoconfirmed|member}}',
1533 -'group-bot-member' => '{{doc-group|bot|member}}',
1534 -'group-sysop-member' => '{{doc-group|sysop|member}}',
1535 -'group-bureaucrat-member' => '{{doc-group|bureaucrat|member}}',
1536 -'group-suppress-member' => '{{doc-group|suppress|member}}
 1531+'group-user-member' => '{{doc-group|user|member}}, can use <nowiki>{{GENDER}}</nowiki>',
 1532+'group-autoconfirmed-member' => '{{doc-group|autoconfirmed|member}}, can use <nowiki>{{GENDER}}</nowiki>',
 1533+'group-bot-member' => '{{doc-group|bot|member}}, can use <nowiki>{{GENDER}}</nowiki>',
 1534+'group-sysop-member' => '{{doc-group|sysop|member}}, can use <nowiki>{{GENDER}}</nowiki>',
 1535+'group-bureaucrat-member' => '{{doc-group|bureaucrat|member}}, can use <nowiki>{{GENDER}}</nowiki>',
 1536+'group-suppress-member' => '{{doc-group|suppress|member}}, can use <nowiki>{{GENDER}}</nowiki>
15371537 This is a member of the optional (disabled by default) user group, meant for the [[mw:RevisionDelete|RevisionDelete]] feature, to change the visibility of revisions through [[Special:RevisionDelete]].
15381538
15391539 {{Identical|Oversight}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r109260Revert r107881 per CR.siebrand00:26, 18 January 2012
r109340Follow-up r107881: revert. Adding forgotten part in r109260.siebrand08:05, 18 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99312Part of bug 31503 - Allow gender distinction also for user groupsnikerabbit14:13, 8 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   12:02, 3 January 2012

Those comments in MessagesEn are not useful, and next rebuild is likely to drop them anyway.

#Comment by Nikerabbit (talk | contribs)   12:03, 3 January 2012

What was the reason for this change?

#Comment by Hashar (talk | contribs)   14:42, 3 January 2012

The GENDER is useless in those english messages. Removing them change nothing and save some useless processing.

The QQQ messages give a hint to translators.

#Comment by Nikerabbit (talk | contribs)   19:32, 3 January 2012

It's also less obvious translators and wiki customizers. And we already updated all the group messages in extensions too.

#Comment by Hashar (talk | contribs)   09:02, 4 January 2012

Nikerabbit, please either mark this ok or revert the change :-) Reseting to new.

Status & tagging log