r107743 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107742‎ | r107743 | r107744 >
Date:21:30, 31 December 2011
Author:reedy
Status:resolved
Tags:
Comment:
Message-ify bitrate units

Add to messageTypes.inc and messages.inc too
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -3281,6 +3281,17 @@
32823282 'size-zetabytes',
32833283 'size-yottabytes',
32843284 ),
 3285+ 'bitrateunits' => array(
 3286+ 'bitrate-bits',
 3287+ 'bitrate-kibibits',
 3288+ 'bitrate-mebibits',
 3289+ 'bitrate-gibibits',
 3290+ 'bitrate-tebibits',
 3291+ 'bitrate-pebibits',
 3292+ 'bitrate-exbibits',
 3293+ 'bitrate-zebibits',
 3294+ 'bitrate-yobibits',
 3295+ ),
32853296 'livepreview' => array(
32863297 'livepreview-loading',
32873298 'livepreview-ready',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -327,6 +327,15 @@
328328 'size-exabytes',
329329 'size-zetabytes',
330330 'size-yottabytes',
 331+ 'bitrate-bits',
 332+ 'bitrate-kibibits',
 333+ 'bitrate-mebibits',
 334+ 'bitrate-gibibits',
 335+ 'bitrate-tebibits',
 336+ 'bitrate-pebibits',
 337+ 'bitrate-exbibits',
 338+ 'bitrate-zebibits',
 339+ 'bitrate-yobibits',
331340 'iranian-calendar-m1',
332341 'iranian-calendar-m2',
333342 'iranian-calendar-m3',
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -4120,6 +4120,26 @@
41214121 'size-yottabytes' => '{{optional}}
41224122 Size (of a file, typically) in yobibytes (1 yobibytes = 1024×1024×1024×1024×1024×1024×1024×1024 bytes).',
41234123
 4124+# Bitrate units
 4125+'bitrate-bits' => '{{optional}}
 4126+Bitrate (of a file, typically) in bits.',
 4127+'bitrate-kibibits' => '{{optional}}
 4128+Bitrate (of a file, typically) in kibibits (1 kibibyte = 1000 bits).',
 4129+'bitrate-mebibits' => '{{optional}}
 4130+Bitrate (of a file, typically) in mebibits (1 mebibyte = 1000×1000 bits).',
 4131+'bitrate-gibibits' => '{{optional}}
 4132+Bitrate (of a file, typically) in gibibits (1 gibibyte = 1000×1000×1000 bits).',
 4133+'bitrate-tebibits' => '{{optional}}
 4134+Bitrate (of a file, typically) in tebibits (1 tebibits = 1000×1000×1000×1000 bits).',
 4135+'bitrate-pebibits' => '{{optional}}
 4136+Bitrate (of a file, typically) in pebibits (1 pebibits = 1000×1000×1000×1000×1000 bits).',
 4137+'bitrate-exbibits' => '{{optional}}
 4138+Bitrate (of a file, typically) in exbibits (1 exbibits = 1000×1000×1000×1000×1000×1000 bits).',
 4139+'bitrate-zebibits' => '{{optional}}
 4140+Bitrate (of a file, typically) in zebibits (1 zebibits = 1000×1000×1000×1000×1000×1000×1000 bits).',
 4141+'bitrate-yobibits' => '{{optional}}
 4142+Bitrate (of a file, typically) in yobibits (1 yobibits = 1000×1000×1000×1000×1000×1000×1000×1000 bits).',
 4143+
41244144 # Live preview
41254145 'livepreview-loading' => '{{Identical|Loading}}',
41264146
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4395,6 +4395,17 @@
43964396 'size-zetabytes' => '$1 ZB', # only translate this message to other languages if you have to change it
43974397 'size-yottabytes' => '$1 YB', # only translate this message to other languages if you have to change it
43984398
 4399+# Bitrate units
 4400+'bitrate-bits' => '$1bps', # only translate this message to other languages if you have to change it
 4401+'bitrate-kibibits' => '$1kbps', # only translate this message to other languages if you have to change it
 4402+'bitrate-mebibits' => '$1Mbps', # only translate this message to other languages if you have to change it
 4403+'bitrate-gibibits' => '$1Gbps', # only translate this message to other languages if you have to change it
 4404+'bitrate-tebibits' => '$1Tbps', # only translate this message to other languages if you have to change it
 4405+'bitrate-pebibits' => '$1Pbps', # only translate this message to other languages if you have to change it
 4406+'bitrate-exbibits' => '$1Ebps', # only translate this message to other languages if you have to change it
 4407+'bitrate-zebibits' => '$1Zbps', # only translate this message to other languages if you have to change it
 4408+'bitrate-yobibits' => '$1Ybps', # only translate this message to other languages if you have to change it
 4409+
43994410 # Live preview
44004411 'livepreview-loading' => 'Loading...',
44014412 'livepreview-ready' => 'Loading... Ready!',

Follow-up revisions

RevisionCommit summaryAuthorDate
r107744Followup r107743, use messages in formatBitrate...reedy21:32, 31 December 2011
r107746Fixup r107744, r107743reedy21:54, 31 December 2011
r107780Fix fixme on r107744 (though, I'm guessing r107743 is at fault, for not addin...reedy20:16, 1 January 2012

Status & tagging log