r107391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107390‎ | r107391 | r107392 >
Date:16:01, 27 December 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
And while I'm at it: don't call DatabaseBase::commit() twice per deletion
Modified paths:
  • /trunk/phase3/maintenance/deleteBatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/deleteBatch.php
@@ -98,7 +98,7 @@
9999 }
100100 $page = WikiPage::factory( $title );
101101 $error = '';
102 - $success = $page->doDeleteArticle( $reason, false, 0, true, $error, $user );
 102+ $success = $page->doDeleteArticle( $reason, false, 0, false, $error, $user );
103103 $dbw->commit();
104104 if ( $success ) {
105105 $this->output( " Deleted!\n" );

Comments

#Comment by Nikerabbit (talk | contribs)   07:01, 28 December 2011

Unreadable code :(

Status & tagging log