r107368 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107367‎ | r107368 | r107369 >
Date:08:19, 27 December 2011
Author:amire80
Status:ok
Tags:
Comment:
Revert r107365.
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialLanguageStats.php (modified) (history)
  • /trunk/extensions/Translate/specials/SpecialMessageGroupStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialMessageGroupStats.php
@@ -107,7 +107,13 @@
108108 function getTable() {
109109 $table = $this->table;
110110
111 - $this->workflowStatesColumn();
 111+ global $wgTranslateWorkflowStates;
 112+ if ( $wgTranslateWorkflowStates ) {
 113+ $this->states = self::getWorkflowStates( $this->target );
 114+ $this->statemap = array_flip( $wgTranslateWorkflowStates );
 115+ $table->addExtraColumn( wfMessage( 'translate-stats-workflow' ) );
 116+ }
 117+
112118 $out = '';
113119
114120 if ( $this->purge ) {
Index: trunk/extensions/Translate/specials/SpecialLanguageStats.php
@@ -229,20 +229,6 @@
230230 }
231231
232232 /**
233 - * Adds a workflow states column if its needed.
234 - */
235 - function workflowStatesColumn() {
236 - global $wgTranslateWorkflowStates;
237 - if ( $wgTranslateWorkflowStates ) {
238 - $this->states = self::getWorkflowStates( $this->target );
239 - $this->statemap = array_flip( $wgTranslateWorkflowStates );
240 - $table->addExtraColumn( wfMessage( 'translate-stats-workflow' ) );
241 - }
242 - return;
243 - }
244 -
245 -
246 - /**
247233 * Returns the table itself.
248234 * @return \string HTML
249235 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107365Refactored workflow states column adding code.amire8007:29, 27 December 2011

Status & tagging log