r107369 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107368‎ | r107369 | r107370 >
Date:08:30, 27 December 2011
Author:amire80
Status:ok
Tags:
Comment:
Follow up to r107367, fixed wrong variables.
Modified paths:
  • /trunk/extensions/Translate/TranslateHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateHooks.php
@@ -330,8 +330,10 @@
331331 $languageCode = $params[0];
332332 $languageNames = Language::getTranslatedLanguageNames( $languageCode );
333333 $languageName = "$languageNames[$languageCode] ($languageCode)";
334 - $oldStateMessage = wfMessage( "translate-workflow-state-$params[2]" );
335 - $newStateMessage = wfMessage( "translate-workflow-state-$params[3]" );
 334+ $oldState = $params[2];
 335+ $newState = $params[3];
 336+ $oldStateMessage = wfMessage( "translate-workflow-state-$oldState" );
 337+ $newStateMessage = wfMessage( "translate-workflow-state-$newState" );
336338 $oldState = $oldStateMessage->isBlank() ? $oldState : $oldStateMessage->text();
337339 $newState = $newStateMessage->isBlank() ? $newState : $newStateMessage->text();
338340
@@ -342,7 +344,7 @@
343345 $params[1], // group
344346 $oldState,
345347 $newState
346 - )->inLanguage( $language )->text() . $bla;
 348+ )->inLanguage( $language )->text();
347349 }
348350
349351 return '';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107367Workflow states logging.amire8008:01, 27 December 2011

Status & tagging log