r107341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107340‎ | r107341 | r107342 >
Date:21:03, 26 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix fixme on r107328, attempting to use $this in a static method

Made said method non static, and updated caller
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -224,7 +224,7 @@
225225 $nt = $userObj->getUserPage();
226226 $talk = $userObj->getTalkPage();
227227 if ( $talk ) {
228 - $tools = self::getUserLinks( $nt, $talk, $userObj, $this->getUser() );
 228+ $tools = $this->getUserLinks( $nt, $talk, $userObj, $this->getUser() );
229229 $links = $this->getLanguage()->pipeList( $tools );
230230
231231 // Show a note if the user is blocked and display the last block log entry.
@@ -270,7 +270,7 @@
271271 * @param $subject User: The viewing user ($wgUser might be still checked in some cases)
272272 * @return array
273273 */
274 - public static function getUserLinks( Title $userpage, Title $talkpage, User $target, User $subject ) {
 274+ public function getUserLinks( Title $userpage, Title $talkpage, User $target, User $subject ) {
275275
276276 $id = $target->getId();
277277 $username = $target->getName();

Follow-up revisions

RevisionCommit summaryAuthorDate
r107394Follow-up r107341: remove now-useless parameterialex16:26, 27 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107328* Use local context to get messages...ialex16:20, 26 December 2011

Comments

#Comment by IAlex (talk | contribs)   16:02, 27 December 2011

Thanks for the fix!

Status & tagging log