r107250 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107249‎ | r107250 | r107251 >
Date:00:06, 25 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Getting a parse error...

Don't set $out to '' to then append...
Modified paths:
  • /trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaDomain.php
@@ -131,9 +131,7 @@
132132 $this->setHeaders();
133133 $this->getOutput()->setPagetitle( wfMsg( 'openstackmanager-domainlist' ) );
134134
135 - $out = '';
136 -
137 - $out .= Linker::( $this->getTitle(), wfMsgHtml( 'openstackmanager-createdomain' ), array(), array( 'action' => 'create' ) );
 135+ $out = Linker::( $this->getTitle(), wfMsgHtml( 'openstackmanager-createdomain' ), array(), array( 'action' => 'create' ) );
138136 $domainsOut = Html::element( 'th', array(), wfMsg( 'openstackmanager-domainname' ) );
139137 $domainsOut .= Html::element( 'th', array(), wfMsg( 'openstackmanager-fqdn' ) );
140138 $domainsOut .= Html::element( 'th', array(), wfMsg( 'openstackmanager-location' ) );

Comments

#Comment by Nikerabbit (talk | contribs)   11:36, 25 December 2011

Well, it's still a parser error.

Status & tagging log