r107248 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107247‎ | r107248 | r107249 >
Date:00:00, 25 December 2011
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Fix i18n for articlefeedbackv5-form2-header.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -55,7 +55,10 @@
5656 'articlefeedbackv5-form-header' => 'Feedback #$1, at $2',
5757 'articlefeedbackv5-form1-header-found' => '{{GENDER:$1|$1}} found what they were looking for:',
5858 'articlefeedbackv5-form1-header-not-found' => '{{GENDER:$1|$1}} did not find what they were looking for:',
59 - 'articlefeedbackv5-form2-header' => '$1 had a $2:',
 59+ 'articlefeedbackv5-form2-header-praise' => '{{GENDER:$1|$1}} had a comment:',
 60+ 'articlefeedbackv5-form2-header-problem' => '{{GENDER:$1|$1}} had a praise:',
 61+ 'articlefeedbackv5-form2-header-question' => '{{GENDER:$1|$1}} had a question:',
 62+ 'articlefeedbackv5-form2-header-suggestion' => '{{GENDER:$1|$1}} had a suggestion:',
6063 'articlefeedbackv5-form3-header' => '$1 rated this page $2/5',
6164 'articlefeedbackv5-form4-header' => 'User was presented with the CTA-only form.',
6265 'articlefeedbackv5-form5-header' => '$1 rated this page:',
@@ -296,6 +299,14 @@
297300 * $1 is a username.',
298301 'articlefeedbackv5-form1-header-not-found' => 'Parameters:
299302 * $1 is a username.',
 303+ 'articlefeedbackv5-form2-header-praise' => 'Parameters:
 304+* $1 is a user name.',
 305+ 'articlefeedbackv5-form2-header-problem' => 'Parameters:
 306+* $1 is a user name.',
 307+ 'articlefeedbackv5-form2-header-question' => 'Parameters:
 308+* $1 is a user name.',
 309+ 'articlefeedbackv5-form2-header-suggestion' => 'Parameters:
 310+* $1 is a user name.',
300311 'articlefeedbackv5-special-title' => 'don\'t touch "== =="',
301312 'articlefeedbackv5' => 'The title of the feature. It is about reader feedback.
302313
Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -217,7 +217,12 @@
218218 private function renderBucket2( $record ) {
219219 $name = htmlspecialchars( $record[0]->user_name );
220220 $type = htmlspecialchars( $record['tag']->afo_name );
221 - return wfMessage( 'articlefeedbackv5-form2-header', $name, $type )->escaped()
 221+ // Document for grepping. Uses any of the messages:
 222+ // * articlefeedbackv5-form2-header-praise
 223+ // * articlefeedbackv5-form2-header-problem
 224+ // * articlefeedbackv5-form2-header-question
 225+ // * articlefeedbackv5-form2-header-suggestion
 226+ return wfMessage( 'articlefeedbackv5-form2-header-' . $type, $name )->escaped()
222227 .'<blockquote>'.htmlspecialchars( $record['comment']->aa_response_text )
223228 .'</blockquote>';
224229 }

Comments

#Comment by SPQRobin (talk | contribs)   03:12, 25 December 2011

Was parameter $2 really hardcoded English? :-S

#Comment by Siebrand (talk | contribs)   08:18, 25 December 2011

Apparently.

Status & tagging log