r107234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107233‎ | r107234 | r107235 >
Date:23:09, 24 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Followup r107011 per Krinkle - "mediawiki.api needs to declare the mediawiki.util dependency."
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
——@@ -499,6 +499,7 @@
500500 ),
501501 'mediawiki.api' => array(
502502 'scripts' => 'resources/mediawiki/mediawiki.api.js',
 503+ 'dependencies' => 'mediawiki.util',
503504 ),
504505 'mediawiki.api.category' => array(
505506 'scripts' => 'resources/mediawiki/mediawiki.api.category.js',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107011[mediawiki.api] clean up...krinkle23:52, 21 December 2011

Comments

#Comment by Krinkle (talk | contribs)   23:13, 24 December 2011

hey, I was just about to commit that :P 

Sending        Resources.php
Transmitting file data .svn: Commit failed (details follow):
svn: File '/trunk/phase3/resources/Resources.php' is out of date
KrinkleMac:resources krinkle$ svn up Resources.php 
G    Resources.php
Updated to revision 107235.
KrinkleMac:resources krinkle$ svn di Resources.php 
KrinkleMac:resources krinkle$

No diff anymore, lol, you already did. Thanks :)

#Comment by Reedy (talk | contribs)   23:14, 24 December 2011

I'm faster than Santas sleigh ;)

With you not being online on IRC, I wasn't sure how "online" you are and whether you'd commit it :)

Status & tagging log