r107195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107194‎ | r107195 | r107196 >
Date:00:23, 24 December 2011
Author:siebrand
Status:resolved
Tags:
Comment:
Use hash key instead of key for lock manager messages. It was confusing translators.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2254,13 +2254,13 @@
22552255 'backend-fail-create' => 'Could not create file $1.',
22562256
22572257 # Lock manager
2258 -'lockmanager-notlocked' => 'Could not unlock key "$1"; it is not locked.',
2259 -'lockmanager-fail-closelock' => 'Could not close lock file for key "$1".',
2260 -'lockmanager-fail-deletelock' => 'Could not delete lock file for key "$1".',
2261 -'lockmanager-fail-acquirelock' => 'Could not acquire lock for key "$1".',
2262 -'lockmanager-fail-openlock' => 'Could not open lock file for key "$1".',
2263 -'lockmanager-fail-releaselock' => 'Could not release lock for key "$1".',
2264 -'lockmanager-fail-acquirelocks' => 'Could not acquire locks for keys "$1".',
 2258+'lockmanager-notlocked' => 'Could not unlock hash key "$1"; it is not locked.',
 2259+'lockmanager-fail-closelock' => 'Could not close lock file for hash key "$1".',
 2260+'lockmanager-fail-deletelock' => 'Could not delete lock file for hash key "$1".',
 2261+'lockmanager-fail-acquirelock' => 'Could not acquire lock for hash key "$1".',
 2262+'lockmanager-fail-openlock' => 'Could not open lock file for hash key "$1".',
 2263+'lockmanager-fail-releaselock' => 'Could not release lock for hash key "$1".',
 2264+'lockmanager-fail-acquirelocks' => 'Could not acquire locks for hash keys "$1".',
22652265 'lockmanager-fail-db-bucket' => 'Could not contact enough lock databases in bucket $1.',
22662266 'lockmanager-fail-db-release' => 'Could not release locks on database $1.',
22672267 'lockmanager-fail-svr-release' => 'Could not release locks on server $1.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r107197* Follow-up r107195: these params are resource paths now, rather than hashes ...aaron00:43, 24 December 2011

Status & tagging log