r107125 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107124‎ | r107125 | r107126 >
Date:00:06, 23 December 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
MFT to 1.18wmf1 r107120

Fix bug 33772 : MoodBar & WikiLove not working on incubator
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/WikimediaIncubator/IncubatorTest.php
@@ -666,7 +666,7 @@
667667 static function fnTestWikiLogo( &$out ) {
668668 $setLogo = self::shouldWeSetCustomLogo( $out->getTitle() );
669669 if( !$setLogo ) {
670 - return false;
 670+ return true;
671671 }
672672 global $wgLogo;
673673 $prefixForPageTitle = str_replace( '/', '-', strtolower( $setLogo['prefix'] ) );
@@ -683,7 +683,7 @@
684684 $wgLogo = $thumb->getUrl();
685685 return true;
686686 }
687 - return false;
 687+ return true;
688688 }
689689 # Use MediaWiki:Incubator-logo-wx-xx(x)
690690 $thumb = $file->transform( array( 'width' => 135, 'height' => 135 ) );
Property changes on: branches/wmf/1.18wmf1/extensions/WikimediaIncubator/IncubatorTest.php
___________________________________________________________________
Added: svn:mergeinfo
691691 Merged /branches/new-installer/phase3/extensions/WikimediaIncubator/IncubatorTest.php:r43664-66004
692692 Merged /branches/wmf-deployment/extensions/WikimediaIncubator/IncubatorTest.php:r60970
693693 Merged /branches/REL1_15/phase3/extensions/WikimediaIncubator/IncubatorTest.php:r51646
694694 Merged /branches/wmf/1.16wmf4/extensions/WikimediaIncubator/IncubatorTest.php:r67177,69199,76243,77266
695695 Merged /trunk/extensions/WikimediaIncubator/IncubatorTest.php:r107120
696696 Merged /branches/sqlite/extensions/WikimediaIncubator/IncubatorTest.php:r58211-58321
697697 Merged /trunk/phase3/extensions/WikimediaIncubator/IncubatorTest.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,80406,81833,83212,83590

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107120A hook function shouldn't return false. This was causing MoodBar & WikiLove t...robin23:09, 22 December 2011

Comments

#Comment by Hashar (talk | contribs)   00:15, 23 December 2011

Deployed live, although mergeinfo were not fetched :-/

Status & tagging log