r107123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107122‎ | r107123 | r107124 >
Date:23:24, 22 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fixup CA js/css per Roan on r106782

Also removed copypasta message from CR
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuth.php (modified) (history)
  • /trunk/extensions/CentralAuth/modules/ext.centralauth.css (modified) (history)
  • /trunk/extensions/CentralAuth/modules/ext.centralauth.noflash.css (added) (history)
  • /trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuth.php
@@ -257,12 +257,15 @@
258258 'remoteExtPath' => 'CentralAuth/modules',
259259 );
260260
261 -// Styles and any code common to all Special:Code subviews:
262261 $wgResourceModules['ext.centralauth'] = array(
263262 'scripts' => 'ext.centralauth.js',
264263 'styles' => 'ext.centralauth.css',
265264 ) + $commonModuleInfo;
266265
 266+$wgResourceModules['ext.centralauth.noflash'] = array(
 267+ 'styles' => 'ext.centralauth.noflash.css',
 268+) + $commonModuleInfo;
 269+
267270 // If AntiSpoof is installed, we can do some AntiSpoof stuff for CA
268271 // Though, doing it this way, AntiSpoof has to be loaded/included first
269272 // I guess this is bug 30234
Index: trunk/extensions/CentralAuth/specials/SpecialCentralAuth.php
@@ -26,6 +26,7 @@
2727 $this->mCanEdit = $this->mCanUnmerge || $this->mCanLock || $this->mCanOversight;
2828
2929 $wgOut->addModules( 'ext.centralauth' );
 30+ $wgOut->addModuleStyles( 'ext.centralauth.noflash' );
3031 $this->addMergeMethodDescriptions();
3132
3233 $this->mUserName =
Index: trunk/extensions/CentralAuth/modules/ext.centralauth.css
@@ -1,10 +1,3 @@
2 -.merge-method-help {
3 - color: #aaa;
4 - cursor: pointer;
5 - font-size: 7pt;
6 - padding: 3px;
7 -}
8 -
92 .merge-method-help-div {
103 position: absolute;
114 z-index: 3;
Index: trunk/extensions/CentralAuth/modules/ext.centralauth.noflash.css
@@ -0,0 +1,6 @@
 2+.merge-method-help {
 3+ color: #aaa;
 4+ cursor: pointer;
 5+ font-size: 7pt;
 6+ padding: 3px;
 7+}
Property changes on: trunk/extensions/CentralAuth/modules/ext.centralauth.noflash.css
___________________________________________________________________
Added: svn:eol-style
18 + native

Sign-offs

UserFlagDate
Nikerabbitinspected09:22, 23 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106782Resourceloader-ify CSS/JS from CentralAuth...reedy12:01, 20 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:23, 23 December 2011

My first reaction was wtf is CA using Flash for.

#Comment by Reedy (talk | contribs)   20:15, 23 December 2011

Haha. My imagination is rubbish

Status & tagging log