r107081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107080‎ | r107081 | r107082 >
Date:18:10, 22 December 2011
Author:rmoen
Status:resolved (Comments)
Tags:
Comment:
added gender support for x thinks this helpful. follow up r106743
Modified paths:
  • /trunk/extensions/MarkAsHelpful/MarkAsHelpful.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MarkAsHelpful/MarkAsHelpful.i18n.php
——@@ -15,7 +15,7 @@
1616 'markashelpful-desc' => 'Provides a user interface to mark comments as helpful',
1717 'mah-mark-text' => 'Mark as helpful',
1818 'mah-you-marked-text' => 'You think this is helpful',
19 - 'mah-someone-marked-text' => '$1 thinks this is helpful',
 19+ 'mah-someone-marked-text' => '{{GENDER:$1|$1}} thinks this is helpful',
2020 'mah-undo-mark-text' => 'undo',
2121 'mah-action-error' => 'There is an error performing this action',
2222 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r107093added method to remove item from array by value to solve bug with reloading i...rmoen19:16, 22 December 2011
r107400updated gender support for who marked as helpful. follow up to r107081rmoen18:09, 27 December 2011
r107403follow up to -r107081 - Add comment to class methods and display only the fir...bsitu18:25, 27 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106743adding some initial language support and documentationrmoen00:55, 20 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   13:56, 23 December 2011

Looks like this is not as straight forward, and message docs seems wrong too: 

39-             foreach ( $helpfulUserList as $val ) {
40-                     $userList .= $val['user_name'] . ' ';
41-             }
42-
43-             $data = '';
44-
45-             if ( $userList ) {
46:                     $data = wfMessage( 'mah-someone-marked-text' )->params( $userList )->escaped();
47-             }

This is a list of users, isntead of just one. It should also use $wgLang->listToText() function.

Status & tagging log