r106964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106963‎ | r106964 | r106965 >
Date:18:58, 21 December 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 33246) News icon shown for news:// URLs but not for news: URLs. Patch by Erwin Dokter
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -151,7 +151,7 @@
152152 background: url(mail_icon.gif) center right no-repeat;
153153 padding-right: 18px;
154154 }
155 -#bodyContent a.external[href ^="news://"] {
 155+#bodyContent a.external[href ^="news:"] {
156156 /* @embed */
157157 background: url(news_icon.png) center right no-repeat;
158158 padding-right: 18px;
Index: trunk/phase3/skins/modern/main.css
@@ -424,7 +424,7 @@
425425 background: url(mail_icon.gif) center right no-repeat;
426426 padding-right: 18px;
427427 }
428 -#mw_content a.external[href ^="news://"] {
 428+#mw_content a.external[href ^="news:"] {
429429 /* @embed */
430430 background: url(news_icon.png) center right no-repeat;
431431 padding-right: 18px;
Index: trunk/phase3/skins/simple/main.css
@@ -239,7 +239,7 @@
240240 background: url(mail_icon.gif) center right no-repeat;
241241 padding-right: 18px;
242242 }
243 -#bodyContent a.external[href ^="news://"] {
 243+#bodyContent a.external[href ^="news:"] {
244244 background: url(news_icon.png) center right no-repeat;
245245 padding-right: 18px;
246246 }
Index: trunk/phase3/skins/vector/screen.css
@@ -715,7 +715,7 @@
716716 background: url(images/mail-icon.png) center right no-repeat;
717717 padding-right: 13px;
718718 }
719 -div#content a.external[href ^="news://"] {
 719+div#content a.external[href ^="news:"] {
720720 /* @embed */
721721 background: url(images/news-icon.png) center right no-repeat;
722722 padding-right: 13px;
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -193,6 +193,7 @@
194194 Special:PrefixIndex rather then re-using Special:AllPages's allinnamespace
195195 * (bug 33156) Special:Block now allows you to confirm you want to block yourself
196196 when using non-normalized username
 197+* (bug 33246) News icon shown for news:// URLs but not for news: URLs
197198
198199 === API changes in 1.19 ===
199200 * (bug 19838) siprop=interwikimap can now use the interwiki cache.

Status & tagging log