r106963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106962‎ | r106963 | r106964 >
Date:18:53, 21 December 2011
Author:ialex
Status:ok
Tags:
Comment:
Declare constant default values directly in the class definition and removed the constructor since it's useless now
Modified paths:
  • /trunk/phase3/includes/cache/LinkCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/LinkCache.php
@@ -9,8 +9,10 @@
1010 // becomes incompatible with the new version.
1111 private $mClassVer = 4;
1212
13 - private $mGoodLinks, $mBadLinks;
14 - private $mForUpdate;
 13+ private $mGoodLinks = array();
 14+ private $mGoodLinkFields = array();
 15+ private $mBadLinks = array();
 16+ private $mForUpdate = false;
1517
1618 /**
1719 * Get an instance of this class
@@ -25,13 +27,6 @@
2628 return $instance;
2729 }
2830
29 - function __construct() {
30 - $this->mForUpdate = false;
31 - $this->mGoodLinks = array();
32 - $this->mGoodLinkFields = array();
33 - $this->mBadLinks = array();
34 - }
35 -
3631 /**
3732 * General accessor to get/set whether SELECT FOR UPDATE should be used
3833 *

Status & tagging log