r106920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106919‎ | r106920 | r106921 >
Date:01:47, 21 December 2011
Author:rmoen
Status:ok (Comments)
Tags:
Comment:
fix duplicate global variable problem in MarkAsHelpful.php, attempt to resolve a relative image problem in css
Modified paths:
  • /trunk/extensions/MarkAsHelpful/MarkAsHelpful.php (modified) (history)
  • /trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MarkAsHelpful/MarkAsHelpful.php
@@ -48,12 +48,12 @@
4949 $wgExtensionMessagesFiles['MarkAsHelpful'] = $dir . 'MarkAsHelpful.i18n.php';
5050
5151 // Resources
52 -$mbResourceTemplate = array(
 52+$mahResourceTemplate = array(
5353 'localBasePath' => $dir . 'modules',
5454 'remoteExtPath' => 'MarkAsHelpful/modules'
5555 );
5656
57 -$wgResourceModules['ext.markAsHelpful'] = $mbResourceTemplate + array(
 57+$wgResourceModules['ext.markAsHelpful'] = $mahResourceTemplate + array(
5858 'styles' => 'ext.markAsHelpful/ext.markAsHelpful.css',
5959 'scripts' => 'ext.markAsHelpful/ext.markAsHelpful.js',
6060 'messages' => array(
@@ -63,4 +63,4 @@
6464 'dependencies' => array(
6565 'mediawiki.util'
6666 ),
67 -);
 67+);
\ No newline at end of file
Index: trunk/extensions/MarkAsHelpful/modules/ext.markAsHelpful/ext.markAsHelpful.css
@@ -4,17 +4,17 @@
55
66 .mw-mah-wrapper .mah-helpful-state {
77 /* @embed */
8 - background: transparent url( images/mah-helpful-dull.png ) left center no-repeat;
 8+ background: transparent url(images/mah-helpful-dull.png) left center no-repeat;
99 padding-left: 18px;
1010 }
1111
1212 .mw-mah-wrapper .mah-helpful-state:hover {
1313 /* @embed */
14 - background: transparent url( images/mah-helpful-hover.png ) left center no-repeat;
 14+ background: transparent url(images/mah-helpful-hover.png) left center no-repeat;
1515 }
1616
1717 .mw-mah-wrapper .mah-helpful-marked-state {
1818 /* @embed */
19 - background: transparent url( images/mah-helpful-marked.png ) left center no-repeat;
 19+ background: transparent url(images/mah-helpful-marked.png) left center no-repeat;
2020 padding-left:18px;
2121 }
\ No newline at end of file

Comments

#Comment by Santhosh.thottingal (talk | contribs)   09:27, 21 December 2011

Which was the duplicate variable? And how could this fix solve it? I just see a rename.

#Comment by Nikerabbit (talk | contribs)   10:02, 21 December 2011

I guess $mbResourceTemplate could conflict with moodbar extension.

#Comment by Robmoen (talk | contribs)   22:34, 21 December 2011

Yes, this resolves two separate issues.

Status & tagging log