r106832 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106831‎ | r106832 | r106833 >
Date:18:45, 20 December 2011
Author:khorn
Status:ok
Tags:
Comment:
Adds a "recurring" key to the stomp message in a way that amounts to it being optional (it should only be set if it's a recurring transaction).
followup r106707
Modified paths:
  • /trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/DonationData.php
@@ -1265,6 +1265,7 @@
12661266 'zip2',
12671267 'gateway',
12681268 'gateway_txn_id',
 1269+ 'recurring',
12691270 'payment_method',
12701271 'payment_submethod',
12711272 'response',
Index: trunk/extensions/DonationInterface/activemq_stomp/activemq_stomp.php
@@ -221,6 +221,7 @@
222222 'postal_code_2' => $transaction['zip2'],
223223 'gateway' => $transaction['gateway'],
224224 'gateway_txn_id' => $transaction['gateway_txn_id'],
 225+ 'recurring' => $transaction['recurring'],
225226 'payment_method' => $transaction['payment_method'],
226227 'payment_submethod' => $transaction['payment_submethod'],
227228 'response' => $transaction['response'],
@@ -234,6 +235,11 @@
235236 //The code there should also be fixed.
236237 'date' => ( int ) $transaction['date'],
237238 );
 239+
 240+ //optional key
 241+ if ( !$message['recurring'] ) {
 242+ unset( $message['recurring'] );
 243+ }
238244
239245 return $message;
240246 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r106896MFT r106707, r106832, r106853, r106854, r106855khorn23:58, 20 December 2011
r106897MFT r106707, r106832, r106853, r106854, r106855khorn23:59, 20 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106707Adds the ability to do recurring payments via globalcollect. All that remains...khorn22:05, 19 December 2011

Status & tagging log