r106801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106800‎ | r106801 | r106802 >
Date:14:15, 20 December 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
* (bug 30671) CentralAuth should globally autologin user on account creation

Fixed per Jeroens comment on the bug

Problem was introduced in r75041 when adding the awful "Also log me in to other wikis of the Wikimedia Foundation" checkbox...
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)
  • /trunk/extensions/CentralAuth/CentralAuthPlugin.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthPlugin.php
@@ -260,7 +260,9 @@
261261
262262 $template->set( 'usedomain', false );
263263
264 - if ( !$wgCentralAuthCookies ) return;
 264+ if ( !$wgCentralAuthCookies ) {
 265+ return;
 266+ }
265267
266268 $label = Xml::checkLabel( wfMsg( 'centralauth-login-global' ), 'wpCentralLogin', 'wpCentralLogin', true, array( 'tabindex' => '4' ) );
267269 $field = <<<HTML
Index: trunk/extensions/CentralAuth/CentralAuthHooks.php
@@ -164,8 +164,11 @@
165165 return true;
166166 }
167167
168 - if ( !$wgRequest->getCheck( 'wpCentralLogin' ) ) {
 168+ if ( !$wgRequest->getCheck( 'wpCentralLogin' ) && !$wgRequest->getVal( 'wpCreateaccount' ) ) {
169169 // The user requested to log in just on this wiki
 170+ // Or they just created an account
 171+ // Thankfully, we don't have the awful "Also log me in to other wikis of the Wikimedia Foundation"
 172+ // on the registration form too... Though, that would've caused this to not happen
170173 return true;
171174 }
172175

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75041Add an option option to not perform a global login (bug 20852)....platonides21:17, 19 October 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   19:13, 20 December 2011

Correct fix is to simply remove the checkbox.

#Comment by Brion VIBBER (talk | contribs)   19:20, 20 December 2011

Obsoleted by r106839 reverting r75041.

Status & tagging log