r106766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106765‎ | r106766 | r106767 >
Date:07:55, 20 December 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
Don't re-use allinnamespace as the header for special:prefixindex. instead introduce new message prefixindex-namespace

Hopefully directly editing MessagesQqq.php like I did is ok... I can never remember if i'm supposed to do that, or if it will just be overridden on next translatewiki export.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1645,6 +1645,7 @@
16461646 'mostrevisions',
16471647 'mostrevisions-summary',
16481648 'prefixindex',
 1649+ 'prefixindex-namespace',
16491650 'prefixindex-summary',
16501651 'shortpages',
16511652 'shortpages-summary',
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -187,6 +187,8 @@
188188 with .xxx causes Internal error
189189 * Warning about undefined index in certain situations when $wgLogRestrictions
190190 causes the first log type requested to be removed but not the others
 191+* Use separate message ('prefixindex-namespace') for title of
 192+ Special:PrefixIndex rather then re-using Special:AllPages's allinnamespace
191193
192194 === API changes in 1.19 ===
193195 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -56,7 +56,7 @@
5757 $namespaces = $wgContLang->getNamespaces();
5858 $out->setPageTitle(
5959 ( $namespace > 0 && in_array( $namespace, array_keys( $namespaces ) ) )
60 - ? $this->msg( 'allinnamespace', str_replace( '_', ' ', $namespaces[$namespace] ) )
 60+ ? $this->msg( 'prefixindex-namespace', str_replace( '_', ' ', $namespaces[$namespace] ) )
6161 : $this->msg( 'prefixindex' )
6262 );
6363
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -2177,6 +2177,7 @@
21782178 'mostimages' => 'Name of special page displayed in [[Special:SpecialPages]]',
21792179 'mostrevisions' => 'Name of special page displayed in [[Special:SpecialPages]]',
21802180 'prefixindex' => 'The page title of [[Special:PrefixIndex]]. When the user limits the list to a certain namespace, {{msg-mw|allinnamespace}} is used instead.',
 2181+'prefixindex-namespace' => 'The page title of [[Special:PrefixIndex]] limited to a specific namespace. Similar to {{msg-mw|allinnamespace}}. $1 is the name of the namespace',
21812182 'shortpages' => 'Name of special page displayed in [[Special:SpecialPages]]',
21822183 'longpages' => 'Name of special page displayed in [[Special:SpecialPages]]',
21832184 'deadendpages' => 'Name of special page displayed in [[Special:SpecialPages]]',
@@ -2250,7 +2251,7 @@
22512252 'allarticles' => 'The page title of [[Special:Allpages]]. When the user limit the list to a certain namespace, {{msg-mw|allinnamespace}} is used instead.
22522253
22532254 {{Identical|All pages}}',
2254 -'allinnamespace' => 'The page title of [[Special:Allpages]] and [[Special:PrefixIndex]], when the user limits the display to a certain namespace. When not limited, {{msg-mw|allarticles}} and {{msg-mw|prefixindex}} is used respectively.
 2255+'allinnamespace' => 'The page title of [[Special:Allpages]], when the user limits the display to a certain namespace. When not limited, {{msg-mw|allarticles}} is used respectively.
22552256
22562257 {{Identical|All pages}}',
22572258 'allnotinnamespace' => 'Presumably intended to be used as a page title of [[Special:Allpages]] and probably also in [[Special:PrefixIndex]] when the user limit the display to other than a certain namespace.
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2545,6 +2545,7 @@
25462546 'mostrevisions' => 'Pages with the most revisions',
25472547 'mostrevisions-summary' => '', # do not translate or duplicate this message to other languages
25482548 'prefixindex' => 'All pages with prefix',
 2549+'prefixindex-namespace' => 'All pages with prefix ($1 namespace)',
25492550 'prefixindex-summary' => '', # do not translate or duplicate this message to other languages
25502551 'shortpages' => 'Short pages',
25512552 'shortpages-summary' => '', # do not translate or duplicate this message to other languages

Comments

#Comment by Siebrand (talk | contribs)   08:35, 20 December 2011

The more you add to qqq, the more translators will love you. Add it in translatewiki.net or in source code, we don't have a preference just as long as it is done. Thanks!

Status & tagging log