r106758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106757‎ | r106758 | r106759 >
Date:04:39, 20 December 2011
Author:tstarling
Status:ok
Tags:
Comment:
* Fix class name
* unset($wgMemc) doesn't actually do anything useful, it just removes the reference from the local scope. Set it to NULL instead.
Modified paths:
  • /trunk/phase3/includes/ForkController.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ForkController.php
@@ -34,7 +34,7 @@
3535
3636 public function __construct( $numProcs, $flags = 0 ) {
3737 if ( php_sapi_name() != 'cli' ) {
38 - throw new MWException( "MultiProcess cannot be used from the web." );
 38+ throw new MWException( "ForkController cannot be used from the web." );
3939 }
4040 $this->procsToStart = $numProcs;
4141 $this->flags = $flags;
@@ -119,7 +119,7 @@
120120 // Don't share DB or memcached connections
121121 wfGetLBFactory()->destroyInstance();
122122 ObjectCache::clear();
123 - unset( $wgMemc );
 123+ $wgMemc = null;
124124 }
125125
126126 /**

Status & tagging log