r106757 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r106756
|
r106757
|
r106758
>
Date:
04:36, 20 December 2011
Author:
tstarling
Status:
ok
Tags:
Comment:
Don't suppress warnings when attempting file creation for the second time, this masks important error messages
Modified paths:
/trunk/phase3/includes/filerepo/backend/lockmanager/FSLockManager.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/filerepo/backend/lockmanager/FSLockManager.php
—
—
@@ -83,9 +83,7 @@
84
84
wfRestoreWarnings();
85
85
if ( !$handle ) { // lock dir missing?
86
86
wfMkdirParents( $this->lockDir );
87
- wfSuppressWarnings();
88
87
$handle = fopen( $this->getLockPath( $key ), 'a+' ); // try again
89
- wfRestoreWarnings();
90
88
}
91
89
if ( $handle ) {
92
90
// Either a shared or exclusive lock
Status & tagging log
04:36, 20 December 2011
Aaron Schulz
(
talk
|
contribs
)
changed the
status
of r106757
[
removed:
new
added:
ok]