r106693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106692‎ | r106693 | r106694 >
Date:20:41, 19 December 2011
Author:catrope
Status:ok
Tags:aft 
Comment:
Modify hook signature for 1.18wmf1 compat
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -318,7 +318,7 @@
319319 */
320320 public static function trackEditSuccess( &$article, &$user, $text,
321321 $summary, $minoredit, $watchthis, $sectionanchor, &$flags,
322 - $revision, &$status, $baseRevId, &$redirect) {
 322+ $revision, &$status, $baseRevId /*, &$redirect */ ) { // $redirect not passed in 1.18wmf1
323323 self::trackEvent( 'edit_success', $article->getTitle() );
324324 return true;
325325 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1066941.18wmf1: Update AFTv5 to trunk state to pick up r106693catrope20:44, 19 December 2011

Status & tagging log