r106685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106684‎ | r106685 | r106686 >
Date:20:20, 19 December 2011
Author:catrope
Status:ok
Tags:aft 
Comment:
For 1.18wmf1 compat, don't use EditPage::getTitle()
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -307,7 +307,7 @@
308308 * @see http://www.mediawiki.org/wiki/Manual:Hooks/EditPage::attemptSave
309309 */
310310 public static function trackEditAttempt( $editpage ) {
311 - self::trackEvent( 'edit_attempt', $editpage->getTitle() );
 311+ self::trackEvent( 'edit_attempt', $editpage->getArticle()->getTitle() ); // EditPage::getTitle() doesn't exist in 1.18wmf1
312312 return true;
313313 }
314314

Follow-up revisions

RevisionCommit summaryAuthorDate
r1066871.18wmf1: Update ArticleFeedbackv5 to trunk state again to pick up r106685catrope20:22, 19 December 2011

Status & tagging log