r106661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106660‎ | r106661 | r106662 >
Date:16:09, 19 December 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r106469, death to $wgTitle
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -307,7 +307,7 @@
308308 * @see http://www.mediawiki.org/wiki/Manual:Hooks/EditPage::attemptSave
309309 */
310310 public static function trackEditAttempt( $editpage ) {
311 - self::trackEvent( 'edit_attempt' );
 311+ self::trackEvent( 'edit_attempt', $editpage->getTitle() );
312312 return true;
313313 }
314314
@@ -319,7 +319,7 @@
320320 public static function trackEditSuccess( &$article, &$user, $text,
321321 $summary, $minoredit, $watchthis, $sectionanchor, &$flags,
322322 $revision, &$status, $baseRevId, &$redirect) {
323 - self::trackEvent( 'edit_success' );
 323+ self::trackEvent( 'edit_success', $article->getTitle() );
324324 return true;
325325 }
326326
@@ -328,10 +328,8 @@
329329 *
330330 * @param $event string the event name
331331 */
332 - private static function trackEvent( $event ) {
333 - global $wgRequest,
334 - $wgArticleFeedbackv5Tracking,
335 - $wgTitle;
 332+ private static function trackEvent( $event, $title ) {
 333+ global $wgRequest, $wgArticleFeedbackv5Tracking;
336334 $ctas = array( 'none', 'edit', 'learn_more' );
337335
338336 $tracking = $wgRequest->getVal( 'articleFeedbackv5_click_tracking' );
@@ -355,8 +353,8 @@
356354 'action' => 'clicktracking',
357355 'eventid' => $trackingId,
358356 'token' => $token,
359 - 'info' => $wgTitle->getText(),
360 - 'namespacenumber' => $wgTitle->getNamespace()
 357+ 'info' => $title->getText(),
 358+ 'namespacenumber' => $title->getNamespace()
361359 ) );
362360 $api = new ApiMain( $params, true );
363361 $api->execute();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106469Added edit tracking and tweaked tracking ids for bug #32992:...rsterbin19:40, 16 December 2011

Status & tagging log