r106660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106659‎ | r106660 | r106661 >
Date:16:05, 19 December 2011
Author:ialex
Status:ok
Tags:
Comment:
* Inlinise the only usage of $user in MediaWiki::main()
* Change the name of the variable containing the WikiPage object for more consistency
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -583,7 +583,6 @@
584584 # Set title from request parameters
585585 $wgTitle = $this->getTitle();
586586 $action = $this->getAction();
587 - $user = $this->context->getUser();
588587
589588 # Send Ajax requests to the Ajax dispatcher.
590589 if ( $wgUseAjax && $action == 'ajax' ) {
@@ -605,8 +604,8 @@
606605 $cache->loadFromFileCache( $this->context );
607606 }
608607 # Do any stats increment/watchlist stuff
609 - $article = WikiPage::factory( $this->getTitle() );
610 - $article->doViewUpdates( $user );
 608+ $page = WikiPage::factory( $this->getTitle() );
 609+ $page->doViewUpdates( $this->context->getUser() );
611610 # Tell OutputPage that output is taken care of
612611 $this->context->getOutput()->disable();
613612 wfProfileOut( 'main-try-filecache' );

Status & tagging log