r106636 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106635‎ | r106636 | r106637 >
Date:10:32, 19 December 2011
Author:siebrand
Status:resolved (Comments)
Tags:
Comment:
* article -> page and other messages tweaks
* added FIXME for potentially superfluous messages and missing plural support
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -6,25 +6,26 @@
77 * @author Brandon Harris
88 * @author Trevor Parscal
99 * @author Arthur Richards
 10+ * @author Siebrand Mazeland
1011 */
1112 $messages['en'] = array(
1213 // CTA translations
1314 'articlefeedbackv5-cta-thanks' => 'Thanks!',
1415 'articlefeedbackv5-cta-confirmation-followup' => 'Your feedback has been saved.',
1516 'articlefeedbackv5-cta1-confirmation-title' => 'Did you know that you can edit this page?',
16 - 'articlefeedbackv5-cta1-confirmation-call' => 'Wikipedia works because anyone can edit its articles. Go ahead, give it a try. Be bold!',
 17+ 'articlefeedbackv5-cta1-confirmation-call' => '{{SITENAME}} works because anyone can edit its pages. Go ahead, give it a try. Be bold!',
1718 'articlefeedbackv5-cta1-learn-how' => 'Learn how to edit',
1819 'articlefeedbackv5-cta1-learn-how-url' => 'http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Tutorial',
1920 'articlefeedbackv5-cta1-edit-linktext' => 'Edit this page',
2021 'articlefeedbackv5-cta2-confirmation-title' => 'Help improve Wikipedia',
21 - 'articlefeedbackv5-cta2-confirmation-call' => 'This encyclopedia is created by people like you. Can you give us a hand?',
 22+ 'articlefeedbackv5-cta2-confirmation-call' => 'This website is created by people like you. Can you give us a hand?',
2223 'articlefeedbackv5-cta2-button-text' => 'Learn more',
2324
2425 // error messages
2526 'articlefeedbackv5-error' => 'An error has occured. Please try again later.',
26 - 'articlefeedbackv5-error-email' => 'That email address is not valid',
27 - 'articlefeedbackv5-error-validation' => 'Validation error',
28 - 'articlefeedbackv5-error-unknown' => 'Unknown error',
 27+ 'articlefeedbackv5-error-email' => 'That e-mail address is not valid.',
 28+ 'articlefeedbackv5-error-validation' => 'Validation error.',
 29+ 'articlefeedbackv5-error-unknown' => 'Unknown error.',
2930 'articlefeedbackv5-error-submit' => 'Form submission error.',
3031 'articlefeedbackv5-error-nofeedback' => 'Please enter your feedback.',
3132 'articlefeedbackv5-error-flagging' => 'Error flagging feedback.',
@@ -39,7 +40,7 @@
4041 'articlefeedbackv5-special-sort-label-after' => '',
4142 'articlefeedbackv5-special-filter-label-before' => 'Show only: ',
4243 'articlefeedbackv5-special-filter-label-after' => '',
43 - 'articlefeedbackv5-special-showing' => 'Showing $1 posts (of $2)',
 44+ 'articlefeedbackv5-special-showing' => 'Showing $1 posts (of $2)', // FIXME: Needs plural support on $1.
4445 'articlefeedbackv5-special-more' => 'More',
4546 'articlefeedbackv5-form-optionid' => 'Option $1',
4647 'articlefeedbackv5-form-hide' => 'Hide this ($1)',
@@ -70,45 +71,45 @@
7172
7273 /* Feedback forms */
7374 /* Option 1 ("Did you find what you were looking for?") */
74 - 'articlefeedbackv5-bucket1-title' => 'Help improve this article',
 75+ 'articlefeedbackv5-bucket1-title' => 'Help improve this page',
7576 'articlefeedbackv5-bucket1-question-toggle' => 'Did you find what you were looking for?',
7677 'articlefeedbackv5-bucket1-toggle-found-yes' => 'Yes',
7778 'articlefeedbackv5-bucket1-toggle-found-no' => 'No',
7879 'articlefeedbackv5-bucket1-toggle-found-yes-full' => 'Yes, I found what I was looking for.',
7980 'articlefeedbackv5-bucket1-toggle-found-no-full' => 'No, I did not find what I was looking for.',
80 - 'articlefeedbackv5-bucket1-question-comment-yes' => 'What was most useful to you? How could this article be improved?',
 81+ 'articlefeedbackv5-bucket1-question-comment-yes' => 'What was most useful to you? How could this page be improved?',
8182 'articlefeedbackv5-bucket1-question-comment-no' => 'What\'s missing? Any suggestions for improvement?',
8283 'articlefeedbackv5-bucket1-form-submit' => 'Post your feedback',
8384 /* Option 2 (getsatisfaction style) */
84 - 'articlefeedbackv5-bucket2-title' => 'Help improve this article',
 85+ 'articlefeedbackv5-bucket2-title' => 'Help improve this page',
8586 'articlefeedbackv5-bucket2-suggestion-label' => 'Suggestion',
8687 'articlefeedbackv5-bucket2-question-label' => 'Question',
8788 'articlefeedbackv5-bucket2-problem-label' => 'Problem',
8889 'articlefeedbackv5-bucket2-praise-label' => 'Praise',
89 - 'articlefeedbackv5-bucket2-suggestion-comment-default' => 'Make a suggestion! How can this article be improved?',
90 - 'articlefeedbackv5-bucket2-question-comment-default' => 'Ask a question about this article.',
91 - 'articlefeedbackv5-bucket2-problem-comment-default' => 'Report a problem. How can this article be improved?',
 90+ 'articlefeedbackv5-bucket2-suggestion-comment-default' => 'Make a suggestion! How can this page be improved?',
 91+ 'articlefeedbackv5-bucket2-question-comment-default' => 'Ask a question about this page.',
 92+ 'articlefeedbackv5-bucket2-problem-comment-default' => 'Report a problem. How can this page be improved?',
9293 'articlefeedbackv5-bucket2-praise-comment-default' => 'What do you like most? Share your praise with the editors.',
9394 'articlefeedbackv5-bucket2-form-submit' => 'Post your feedback',
9495 /* Option 3 (single rating) */
95 - 'articlefeedbackv5-bucket3-title' => 'Help improve this article',
96 - 'articlefeedbackv5-bucket3-rating-question' => 'Is this article helpful?',
 96+ 'articlefeedbackv5-bucket3-title' => 'Help improve this page',
 97+ 'articlefeedbackv5-bucket3-rating-question' => 'Is this page helpful?',
9798 'articlefeedbackv5-bucket3-rating-tooltip-1' => 'Not helpful at all',
9899 'articlefeedbackv5-bucket3-rating-tooltip-2' => 'Not very helpful',
99100 'articlefeedbackv5-bucket3-rating-tooltip-3' => 'Average',
100101 'articlefeedbackv5-bucket3-rating-tooltip-4' => 'Helpful',
101102 'articlefeedbackv5-bucket3-rating-tooltip-5' => 'Very helpful',
102103 'articlefeedbackv5-bucket3-clear-rating' => 'Remove this rating',
103 - 'articlefeedbackv5-bucket3-comment-default' => 'Add a comment. How can this article be improved?',
 104+ 'articlefeedbackv5-bucket3-comment-default' => 'Add a comment. How can this page be improved?',
104105 'articlefeedbackv5-bucket3-form-submit' => 'Post your feedback',
105106 /* Option 4 (just a big glossy edit button and some teaser text) */
106 - 'articlefeedbackv5-bucket4-title' => 'Help improve this article',
 107+ 'articlefeedbackv5-bucket4-title' => 'Help improve this page',
107108 'articlefeedbackv5-bucket4-subhead' => 'Did you know that you can edit this page?',
108 - 'articlefeedbackv5-bucket4-teaser-line1' => 'Wikipedia works because anyone can edit its articles.',
 109+ 'articlefeedbackv5-bucket4-teaser-line1' => 'Wikipedia works because anyone can edit its pages.',
109110 'articlefeedbackv5-bucket4-teaser-line2' => 'Go ahead, give it a try. Be bold!',
110111 'articlefeedbackv5-bucket4-learn-to-edit' => 'Learn how to edit',
111112 'articlefeedbackv5-bucket4-form-submit' => 'Edit this page',
112 - 'articlefeedbackv5-bucket4-help-tooltip-info' => 'Wikipedia wants to know what you think. Help improve this page by becoming an editor.',
 113+ 'articlefeedbackv5-bucket4-help-tooltip-info' => '{{SITENAME}} wants to know what you think. Help improve this page by becoming an editor.',
113114 /* Option 5 (just like AFTv4, but ported to work with v5) */
114115 'articlefeedbackv5-bucket5-form-switch-label' => 'Rate this page',
115116 'articlefeedbackv5-bucket5-form-panel-title' => 'Rate this page',
@@ -133,7 +134,7 @@
134135 'articlefeedbackv5-bucket5-report-panel-title' => 'Page ratings',
135136 'articlefeedbackv5-bucket5-report-panel-description' => 'Current average ratings.',
136137 'articlefeedbackv5-bucket5-report-empty' => 'No ratings',
137 - 'articlefeedbackv5-bucket5-report-ratings' => '$1 ratings',
 138+ 'articlefeedbackv5-bucket5-report-ratings' => '$1 ratings', // FIXME: Needs plural support for $1.
138139 'articlefeedbackv5-bucket5-trustworthy-label' => 'Trustworthy',
139140 'articlefeedbackv5-bucket5-trustworthy-tip' => 'Do you feel this page has sufficient citations and that those citations come from trustworthy sources?',
140141 'articlefeedbackv5-bucket5-trustworthy-tooltip-1' => 'Lacks reputable sources',
@@ -167,18 +168,19 @@
168169 'articlefeedbackv5-shared-on-feedback' => 'Your comment will be shared on this $1.',
169170 'articlefeedbackv5-shared-on-feedback-linktext' => 'feedback page',
170171 'articlefeedbackv5-help-tooltip-title' => 'What\'s this?',
171 - 'articlefeedbackv5-help-tooltip-info' => 'Wikipedia would like to hear what you think of this article. Share your feedback with the editors -- and help improve this page.',
 172+ 'articlefeedbackv5-help-tooltip-info' => '{{SITENAME}} would like to hear what you think of this page. Share your feedback with the editors -- and help improve this page.',
172173 'articlefeedbackv5-help-tooltip-linktext' => 'Learn more',
173174 'articlefeedbackv5-help-tooltip-linkurl' => 'http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Version_5/Help',
174175 'articlefeedbackv5-transparency-terms' => 'By posting, you agree to transparency under these $1.',
175176 'articlefeedbackv5-transparency-terms-linktext' => 'terms',
176177 'articlefeedbackv5-transparency-terms-url' => 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
177178 'articlefeedbackv5-section-linktext' => 'feedback',
178 - 'articlefeedbackv5-titlebar-linktext' => 'Help improve this article >>',
 179+ 'articlefeedbackv5-titlebar-linktext' => 'Help improve this page >>',
179180 'articlefeedbackv5-fixedtab-linktext' => 'Improve this page',
180181 'articlefeedbackv5-toolbox-linktext' => 'Improve this page',
181182
182183 /* --- copied from AFTv4 and possibly not used --- */
 184+ // FIXME: Can we get clarity on this? Translators may be wasting their time here (!!!)
183185 /* ArticleFeedback survey */
184186 'articlefeedbackv5-survey-question-origin' => 'What page were you on when you started this survey?',
185187 'articlefeedbackv5-survey-question-whyrated' => 'Please let us know why you rated this page today (check all that apply):',
@@ -223,10 +225,10 @@
224226 'articleFeedbackv5-table-heading-page' => 'Page',
225227 'articleFeedbackv5-table-heading-average' => 'Average',
226228 'articlefeedbackv5-table-noratings' => '-',
227 - 'articleFeedbackv5-copy-above-highlow-tables' => 'This is an experimental feature. Please provide feedback on the [$1 discussion page].',
228 - 'articlefeedbackv5-dashboard-bottom' => "'''Note''': We will continue to experiment with different ways of surfacing articles in these dashboards. At present, the dashboards include the following articles:
229 -* Pages with highest/lowest ratings: articles that have received at least 10 ratings within the last 24 hours. Averages are calculated by taking the mean of all ratings submitted within the last 24 hours.
230 -* Recent lows: articles that got 70% or more low (2 stars or lower) ratings in any category in the last 24 hours. Only articles that have received at least 10 ratings in the last 24 hours are included.",
 229+ 'articleFeedbackv5-copy-above-highlow-tables' => 'This is an experimental feature. Please provide feedback on the [$1 discussion page].',
 230+ 'articlefeedbackv5-dashboard-bottom' => "'''Note''': We will continue to experiment with different ways of surfacing pages in these dashboards. At present, the dashboards include the following pages:
 231+* Pages with highest/lowest ratings: pages that have received at least 10 ratings within the last 24 hours. Averages are calculated by taking the mean of all ratings submitted within the last 24 hours.
 232+* Recent lows: pages that got 70% or more low (2 stars or lower) ratings in any category in the last 24 hours. Only pages that have received at least 10 ratings in the last 24 hours are included.",
231233 /* Special:Preferences */
232234 'articlefeedbackv5-disable-preference' => "Don't show the Article feedback widget on pages",
233235 /* EmailCapture */

Follow-up revisions

RevisionCommit summaryAuthorDate
r106663Fix r106636, r106653: revert {{SITENAME}} changes, can't use {{SITENAME}} in ...catrope16:17, 19 December 2011

Comments

#Comment by Catrope (talk | contribs)   16:03, 19 December 2011
-	'articlefeedbackv5-cta1-confirmation-call' => 'Wikipedia works because anyone can edit its articles. Go ahead, give it a try. Be bold!',
+	'articlefeedbackv5-cta1-confirmation-call' => '{{SITENAME}} works because anyone can edit its pages. Go ahead, give it a try. Be bold!',

You cannot use MediaWiki in JS messages.

#Comment by Catrope (talk | contribs)   16:04, 19 December 2011

Ahm, what I meant of course is "You cannot use {{SITENAME}}"

Status & tagging log