r106619 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106618‎ | r106619 | r106620 >
Date:01:07, 19 December 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
@private is a lie, based on usage, it'd need to be at least protected

Removing useless documentation replacing with param/return doc
Modified paths:
  • /trunk/phase3/includes/context/RequestContext.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/context/RequestContext.php
——@@ -146,7 +146,8 @@
147147 /**
148148 * Accepts a language code and ensures it's sane. Outputs a cleaned up language
149149 * code and replaces with $wgLanguageCode if not sane.
150 - * @private
 150+ * @param $code string
 151+ * @return string
151152 */
152153 static function sanitizeLangCode( $code ) {
153154 global $wgLanguageCode;

Follow-up revisions

RevisionCommit summaryAuthorDate
r106672Followup r106619, mark said method public due to callersreedy19:07, 19 December 2011

Comments

#Comment by 😂 (talk | contribs)   15:59, 19 December 2011

If you're going to remove a fake visibility, add a real one.

Status & tagging log